From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11633 invoked by alias); 14 Oct 2003 05:53:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11626 invoked from network); 14 Oct 2003 05:53:41 -0000 Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173) by sources.redhat.com with SMTP; 14 Oct 2003 05:53:41 -0000 Received: from [207.232.27.5] (helo=WST0054) by monty-python.gnu.org with asmtp (Exim 4.24) id 1A9I70-00078q-BB; Tue, 14 Oct 2003 01:52:50 -0400 Date: Tue, 14 Oct 2003 05:53:00 -0000 Message-Id: From: Eli Zaretskii To: Kevin Buettner CC: gdb-patches@sources.redhat.com In-reply-to: <1031013234730.ZM23298@localhost.localdomain> (message from Kevin Buettner on Mon, 13 Oct 2003 16:47:30 -0700) Subject: Re: [RFA/doc] TARGET_ADJUST_BREAKPOINT_ADDRESS - patch 2 of 4 Reply-to: Eli Zaretskii References: <1031004030829.ZM24969@localhost.localdomain> <7105-Tue07Oct2003233813+0200-eliz@elta.co.il> <1031013234730.ZM23298@localhost.localdomain> X-SW-Source: 2003-10/txt/msg00441.txt.bz2 > Date: Mon, 13 Oct 2003 16:47:30 -0700 > From: Kevin Buettner > > How about the following? > > * gdb.texinfo (Breakpoint related warnings): New node. > * gdbint.texinfo (ADJUST_BREAKPOINT_ADDRESS): Document. Thanks; approved with the following comments: > +Some processor architectures place constraints on the addresses at > +which breakpoints may be placed. For architectures thus constrained, > +GDB will attempt to adjust the breakpoint's address to comply with the > +constraints dictated by the architecture. "GDB" here should be "@value{GDBN}". > + Upon seeing one of these warnings, the user > +should verify that a breakpoint set at the adjusted address will have > +the desired affect. I suggest to say "If you see one of these warnings, you should verify that a breakpoint ..." instead. > +E.g, it may be sufficient to place the breakpoint at a later instruction. The "e.g." here lacks a period after `g'. > +@value{GDBN} will also issue a warning when stopping at one of these > +adjusted breakpoints: > + > +@smallexample > +warning: Breakpoint 1 address previously adjusted from 0x00010414 to 0x00010410. > +@end smallexample This will almost certainly produce an overfull box when TeX'ed. I suggest to break the long line into two (if you think it's important to know that the message is one long line, you can add a comment to that effect). > +@item ADJUST_BREAKPOINT_ADDRESS (@var{address}) > +@findex ADJUST_BREAKPOINT_ADDRESS > +Given an address at which a breakpoint is desired, return a breakpoint > +address adjusted to account for architectural constraints on > +breakpoint placement. This method is not needed by most targets. I'd add a @cindex entry here as well.