From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-49434-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27962 invoked by alias); 16 Jun 2007 10:21:02 -0000
Received: (qmail 27946 invoked by uid 22791); 16 Jun 2007 10:21:01 -0000
X-Spam-Check-By: sourceware.org
Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (213.8.233.22)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 16 Jun 2007 10:20:58 +0000
Received: from HOME-C4E4A596F7 (IGLD-83-130-245-228.inter.net.il [83.130.245.228]) 	by nitzan.inter.net.il (MOS 3.7.3a-GA) 	with ESMTP id GZQ00284 (AUTH halo1); 	Sat, 16 Jun 2007 13:20:58 +0300 (IDT)
Date: Sat, 16 Jun 2007 10:21:00 -0000
Message-Id: <u7iq4i4je.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
CC: drow@false.org, schwab@suse.de, gdb-patches@sources.redhat.com
In-reply-to: <200706152305.25699.vladimir@codesourcery.com> (message from 	Vladimir Prus on Fri, 15 Jun 2007 23:05:25 +0400)
Subject: Re: ColdFire/fido support
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <200705051337.02114.vladimir@codesourcery.com> <200706151417.25052.vladimir@codesourcery.com> <20070615144758.GA10833@caradoc.them.org> <200706152305.25699.vladimir@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-06/txt/msg00307.txt.bz2

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Fri, 15 Jun 2007 23:05:25 +0400
> Cc: Andreas Schwab <schwab@suse.de>,  gdb-patches@sources.redhat.com,  Eli Zaretskii <eliz@gnu.org>
> 
> Does this doco patch look good?

It's okay, but I'd prefer to convert the two subsections--the old ARM
one and the new one you wrote--into @node's, and add a menu in their
parent.  With two targets (and more to come, I presume), it is no
longer a good idea to hide those subsections from the menu traversing
commands of an Info reader.

> +An M68K target is required to have either the
> +@samp{org.gnu.gdb.m68k.core} feature or the
> +@samp{org.gnu.gdb.coldfire.core} feature or the 
> +@samp{org.gnu.gdb.fido.core} feature.  Which feature is present
> +determines which flavour of m68k is used.  The present feature 
> +should contain registers @samp{d0} through @samp{d7}, 
> +@samp{a0} through @samp{a5}, @samp{fp}, @samp{sp}, @samp{ps} and 
> +@samp{pc}.
> +
> +The @samp{org.gnu.gdb.coldfire.fp} feature is optional.  If present, it
> +should contain registers @samp{fp0} through @samp{fp7},
> +@samp{fpcontrol}, @samp{fpstatus} and @samp{fpiaddr}.

Isn't it better to use an @itemize list here?  How about the following
rewording:

    @node M68K Features
    @subsection M68K Features
    @cindex target descriptions, M68K features

    An M68K target can have either one of the following features:
    @itemize @bullet{}
    @item
    @samp{org.gnu.gdb.m68k.core}
    @itemx
    @samp{org.gnu.gdb.coldfire.core}
    @itemx
    @samp{org.gnu.gdb.fido.core}
    The feature that is present determines which flavor of m86k is
    used.  The feature that is present should contain registers
    @samp{d0} through @samp{d7}, @samp{a0} through @samp{a5}, @samp{fp},
    @samp{sp}, @samp{ps} and @samp{pc}.

    @item
    @samp{org.gnu.gdb.coldfire.fp}
    This feature is optional.  If present, it should contain registers
    @samp{fp0} through @samp{fp7}, @samp{fpcontrol}, @samp{fpstatus} and
    @samp{fpiaddr}.
    @end itemize

Finally, please use the US English variant of spelling: "flavor", not
"flavour".