From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22496 invoked by alias); 17 Jan 2006 20:17:17 -0000 Received: (qmail 22488 invoked by uid 22791); 17 Jan 2006 20:17:17 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 17 Jan 2006 20:17:15 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-4-200.inter.net.il [80.230.4.200]) by nitzan.inter.net.il (MOS 3.7.3-GA) with ESMTP id CML35566 (AUTH halo1); Tue, 17 Jan 2006 21:59:49 +0200 (IST) Date: Tue, 17 Jan 2006 20:17:00 -0000 Message-Id: From: Eli Zaretskii To: Jim Blandy CC: gdb-patches@sourceware.org In-reply-to: <8f2776cb0601171137yffbcd4exefdefe7c8a79bbf3@mail.gmail.com> (message from Jim Blandy on Tue, 17 Jan 2006 11:37:29 -0800) Subject: Re: [ob] More warnings; Call for assistance Reply-to: Eli Zaretskii References: <20060117151730.GA2420@nevyn.them.org> <20060117152156.GA3115@nevyn.them.org> <8f2776cb0601171137yffbcd4exefdefe7c8a79bbf3@mail.gmail.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00223.txt.bz2 > Date: Tue, 17 Jan 2006 11:37:29 -0800 > From: Jim Blandy > > I gather what this is suggesting is that we have a big switch > selecting an appropriate call to printf that uses a fixed format > string. > > There will be dozens of cases there, due to the modifiers (h, l, ll, > precision, leading sign, alternative form). The precisions will need > to be parsed when present; sometimes they are minimum values, > sometimes they are maximum values. Since we check the number and type > of the arguments, I think -Wformat-nonliteral is the right answer > here. I don't see a benefit to making this change that justifies the > risk of mistakes. > > What do folks think? I think that GCC warning is silly to begin with, so "-Wformat-nonliteral" sounds good to me.