From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13335 invoked by alias); 20 Jul 2006 19:24:15 -0000 Received: (qmail 13327 invoked by uid 22791); 20 Jul 2006 19:24:15 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Jul 2006 19:24:13 +0000 Received: from HOME-C4E4A596F7 (IGLD-83-130-247-14.inter.net.il [83.130.247.14]) by nitzan.inter.net.il (MOS 3.7.3-GA) with ESMTP id EFM94686 (AUTH halo1); Thu, 20 Jul 2006 22:24:07 +0300 (IDT) Date: Thu, 20 Jul 2006 19:24:00 -0000 Message-Id: From: Eli Zaretskii To: Andrew STUBBS CC: gdb-patches@sources.redhat.com In-reply-to: <44BFB35D.9080609@st.com> (message from Andrew STUBBS on Thu, 20 Jul 2006 17:46:21 +0100) Subject: Re: [PATCH] command trace / source verbose mode Reply-to: Eli Zaretskii References: <437B6228.8010103@st.com> <437C9C07.4020707@st.com> <20060706131559.GA18827@nevyn.them.org> <44AD46E2.6020207@st.com> <20060706173315.GA26692@nevyn.them.org> <44AE8922.7070704@st.com> <44BFB35D.9080609@st.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00273.txt.bz2 > Date: Thu, 20 Jul 2006 17:46:21 +0100 > From: Andrew STUBBS > Cc: gdb-patches@sources.redhat.com > > Here is an updated version of my patch. I think I have addressed all > your points. Thanks. > - if (file == NULL) > + if (file == NULL || strlen (file) == 0) ^^^^^^^^^^^^^^^^^^ Nitpicking: isn't it better to use *file == 0 instead? > error (_("source command requires pathname of file to source.")); Another nit: the GNU project does not like to use ``pathname''; please use ``file name'' (yes, two words) instead. > +Optional -v switch (before the filename) causes each command in\n\ > +FILE to be echo as it is executed.\n\ ^^^^^^^^^^ You meant "to be echoed", right? > Note that the file \"%s\" is read automatically in this way\n\ > when gdb is started."), gdbinit); I think "gdb" should be up-cased. > +If you need to debug user-defined commands or sourced files you may find it > +useful to enable command tracing. This paragraph could benefit from two small changes: . enclose "command tracing" in the above sentence in @dfn{}, to make it stand out--this is a new term you are introducing here . add "@cindex command tracing" before the paragraph Otherwise, the patch is okay with me. Thanks.