From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31472 invoked by alias); 31 Jul 2006 17:16:56 -0000 Received: (qmail 31463 invoked by uid 22791); 31 Jul 2006 17:16:55 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (192.114.186.73) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 31 Jul 2006 17:16:49 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-228-246-135.inter.net.il [84.228.246.135]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id ACX86106 (AUTH halo1); Mon, 31 Jul 2006 20:16:36 +0300 (IDT) Date: Mon, 31 Jul 2006 17:16:00 -0000 Message-Id: From: Eli Zaretskii To: Vladimir Prus CC: gdb-patches@sources.redhat.com In-reply-to: <200607311622.58927.vladimir@codesourcery.com> (message from Vladimir Prus on Mon, 31 Jul 2006 16:22:57 +0400) Subject: Re: [PATCH] remove download_write_size variable Reply-to: Eli Zaretskii References: <200607181648.45180.vladimir@codesourcery.com> <20060718204203.GA27666@nevyn.them.org> <200607311622.58927.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00432.txt.bz2 > From: Vladimir Prus > Date: Mon, 31 Jul 2006 16:22:57 +0400 > Cc: gdb-patches@sources.redhat.com > > > > * symfile.c (download_write_size): Remove. > > > (show_download_write_size): Remove. > > > (load_section_callback): Don't use download_write_size. > > > (_initialize_symfile): Don't register download_write_size. > > > > I can find references to download-write-size on the Internet, e.g. in > > FAQs suggesting how to get better write performance. They all seem to > > push it as high as memory-write-packet-size, though, which suggests we > > do not need both limits. > > > > I think it's reasonable to remove it. However, you'll have to also > > remove it from the manual (it's a documented command). > > Are you sure? Grep does not find any occurrence in docs, on current mainline. It's in the node called "Target Commands". > === gdb/NEWS > ================================================================== > --- gdb/NEWS (/mirrors/gdb) (revision 315) > +++ gdb/NEWS (/patches/download_write_size/gdb) (revision 315) > @@ -18,6 +18,8 @@ > Kernel Object Display, an embedded debugging feature which only worked with > an obsolete version of Cisco IOS. > > +The 'download_write_size' variable. > + This variable is not user-visible. You need to mention the command, not the C variable.