From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21506 invoked by alias); 5 Jan 2007 12:56:47 -0000 Received: (qmail 21490 invoked by uid 22791); 5 Jan 2007 12:56:44 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 Jan 2007 12:56:36 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-229-200-31.inter.net.il [84.229.200.31]) by nitzan.inter.net.il (MOS 3.7.3a-GA) with ESMTP id FQR58912 (AUTH halo1); Fri, 5 Jan 2007 14:56:33 +0200 (IST) Date: Fri, 05 Jan 2007 12:56:00 -0000 Message-Id: From: Eli Zaretskii To: Daniel Jacobowitz CC: gdb-patches@sourceware.org In-reply-to: <20070104221622.GM24634@nevyn.them.org> (message from Daniel Jacobowitz on Thu, 4 Jan 2007 17:16:22 -0500) Subject: Re: [rfc] Let the remote protocol report the target's arch Reply-to: Eli Zaretskii References: <20061207165207.GA16505@nevyn.them.org> <20070104221622.GM24634@nevyn.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00185.txt.bz2 > Date: Thu, 4 Jan 2007 17:16:22 -0500 > From: Daniel Jacobowitz > > When you get a chance, could you look at this? It's not too urgent; I > need to work on the next patch in this series, since I've forgotten > where I was over the last month. > > Original patch is here: > http://sourceware.org/ml/gdb-patches/2006-12/msg00100.html Sorry, I've managed to miss the fact that portions of this patch await my review. On to it now. > +Access the target's @dfn{target description}. @xref{Target Descriptions}. The ``target's target description''? Wouldn't this be better: Access the @dfn{target description}. > +annex specifies which XML document to access. The main description is > +always loaded from @samp{target.xml}. Is `target.xml' a literal file name, or is the `target' part something that will be replaced with a specific target name? If the former, please use @file{target.xml}, if the latter, @file{@var{target}.xml}. If it's not a file at all, I think this text needs to explain what it is. Similar problems with the markup of target.xml are elsewhere in the patch. > +@node Target Descriptions > +@appendix Target Descriptions Please add a suitable @cindex entry here, for those who will look for this stuff because they remember it's described somewhere in the manual. > +Alternatively, you can specify a file to read for the target description. > +If a file is set, the target will not be queried. > + > +@table @code > +@cindex set tdesc filename > +@item set tdesc filename @var{path} I suggest a sentence before @table to explain what is described in this table. > If @var{path} is empty, > +use the target-supplied description. This sentence is unclear, at least to me: what is this target-supplied description, and where does one find it? If it's target.xml, then how about mentioning it here explicitly? > +@node Target Description Format > +@section Target Description Format Suggest an @cindex entry here as well: someone could be looking for this format description. > +@example > + > + i386:x86-64 > + > +@end example > + > +@noindent > +This description only says that the target uses the x86-64 architecture. > +describes a simple target feature set which only contains two > +registers, named @code{s0} (a 32-bit integer register) and @code{s1} > +(a 32-bit floating point register). Something's missing here, before the "describes a simple target" part. > +The content of the @samp{} element is an architecture > +name, from the same selection accepted by @code{set architecture} There's no `' element in the example that precedes this text, which is confusing. You should probably rewrite the example. > +set tdesc filename > +show tdesc filename > + Read an XML target description from the specified local file instead > + of querying the target for its description. Actually, "set tdesc filename" command doesn't read anything, it just sets the name of the file from which to read the description. Anyway, I think NEWS should say explicitly that GDB can now read a description of remote target's features from an XML file. Then these two new commands will make sense to the reader.