From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9053 invoked by alias); 27 Jan 2007 12:24:26 -0000 Received: (qmail 9041 invoked by uid 22791); 27 Jan 2007 12:24:25 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (213.8.233.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 27 Jan 2007 12:24:19 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-247-172.inter.net.il [80.230.247.172]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id BSK33443 (AUTH halo1); Sat, 27 Jan 2007 14:23:56 +0200 (IST) Date: Sat, 27 Jan 2007 12:24:00 -0000 Message-Id: From: Eli Zaretskii To: Daniel Jacobowitz CC: gdb-patches@sources.redhat.com In-reply-to: <20070120203352.GD25573@nevyn.them.org> (message from Daniel Jacobowitz on Sat, 20 Jan 2007 15:33:52 -0500) Subject: Re: [RFA] Allow use of breakpoint commands inside `if' or `while' Reply-to: Eli Zaretskii References: <20070120203352.GD25573@nevyn.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00551.txt.bz2 > Date: Sat, 20 Jan 2007 15:33:52 -0500 > From: Daniel Jacobowitz > Cc: gdb-patches@sources.redhat.com > > > > Here it is. It is admittedly inelegant; in particular, the > > diagnostics for a GDB that fails the test is not very smart, and one > > of the two tests isn't counted in the sum of failed tests, although it > > does fail. Hopefully, someone more fluent with Expect will be able to > > improve on the test (I think Daniel offered help back when I first > > reported this). > > I did indeed. How does this look? Looks fine, thanks. With an unpatched GDB it fails: Running ./gdb.base/commands.exp ... FAIL: gdb.base/commands.exp: commands - if_commands_test 1 FAIL: gdb.base/commands.exp: silent - if_commands_test 1 FAIL: gdb.base/commands.exp: set $tem = 3 - if_commands_test 1 FAIL: gdb.base/commands.exp: continue - if_commands_test 1 FAIL: gdb.base/commands.exp: first end - if_commands_test 1 FAIL: gdb.base/commands.exp: second end - if_commands_test 1 FAIL: gdb.base/commands.exp: commands - if_commands_test 2 FAIL: gdb.base/commands.exp: silent - if_commands_test 2 FAIL: gdb.base/commands.exp: set $tem = 3 - if_commands_test 2 FAIL: gdb.base/commands.exp: continue - if_commands_test 2 FAIL: gdb.base/commands.exp: first end - if_commands_test 2 FAIL: gdb.base/commands.exp: second end - if_commands_test 2 === gdb Summary === # of expected passes 95 # of unexpected failures 12 make[1]: *** [just-check] Error 1 While after patching it succeeds: Running ./gdb.base/commands.exp ... === gdb Summary === # of expected passes 107