From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18339 invoked by alias); 23 Apr 2008 17:55:27 -0000 Received: (qmail 18328 invoked by uid 22791); 23 Apr 2008 17:55:26 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 23 Apr 2008 17:55:02 +0000 Received: from HOME-C4E4A596F7 ([83.130.1.82]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0JZS006WEIEH2TG0@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Wed, 23 Apr 2008 21:08:41 +0300 (IDT) Date: Wed, 23 Apr 2008 19:46:00 -0000 From: Eli Zaretskii Subject: Re: [rfc, rfa/doc] Multi-threaded watchpoint improvements In-reply-to: X-012-Sender: halo1@inter.net.il To: Andreas Schwab Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: Content-transfer-encoding: 7BIT References: <20070916183949.GA23966@caradoc.them.org> <20071001002015.GA15835@caradoc.them.org> <20080416224910.GA3716@caradoc.them.org> <20080416231831.GB6274@caradoc.them.org> <20080417123455.GA25679@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00526.txt.bz2 > From: Andreas Schwab > Date: Wed, 23 Apr 2008 13:15:47 +0200 > > Here's a patch. OK? > > Andreas. > > 2008-04-23 Andreas Schwab > > * target.h (struct target_ops): Add > to_watchpoint_addr_within_range. > (target_watchpoint_addr_within_range): New function. > * target.c (update_current_target): Inherit > to_watchpoint_addr_within_range, defaulting to > default_watchpoint_addr_within_range. > (default_watchpoint_addr_within_range): New function. > (debug_to_watchpoint_addr_within_range): New function. > (setup_target_debug): Set to_watchpoint_addr_within_range. > * ppc-linux-nat.c (ppc_linux_watchpoint_addr_within_range): > New function. > (_initialize_ppc_linux_nat): Set to_watchpoint_addr_within_range. > * breakpoint.c (watchpoints_triggered): Use > target_watchpoint_addr_within_range. > > doc/: > * gdbint.texinfo (Algorithms): Describe > target_watchpoint_addr_within_range. The patch to gdbint.texinfo is approved, with one comment: > +Check whether @var{addr} (as returned by target_stopped_data_address) target_stopped_data_address should have the @code markup, since it's a C symbol. > + This only needs to be provided if the > +granularity of a watchpoint is greater than one byte Strictly speaking, I think it's needed only if watchpoint's granularity is greater than the granularity of data addresses, but that's nitpicking.