From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19044 invoked by alias); 19 Sep 2008 15:28:31 -0000 Received: (qmail 19036 invoked by uid 22791); 19 Sep 2008 15:28:30 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 19 Sep 2008 15:27:52 +0000 Received: from HOME-C4E4A596F7 ([77.127.116.246]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K7G00BWY8BT8H60@i-mtaout7.012.net.il> for gdb-patches@sourceware.org; Fri, 19 Sep 2008 18:28:46 +0300 (IDT) Date: Fri, 19 Sep 2008 15:28:00 -0000 From: Eli Zaretskii Subject: Re: [RFA 02/08] multi-process support: all targets manage inferior list In-reply-to: <200809191459.10948.pedro@codesourcery.com> X-012-Sender: halo1@inter.net.il To: Pedro Alves Cc: drow@false.org, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: <200809121638.18399.pedro@codesourcery.com> <20080918225118.GD1691@caradoc.them.org> <200809191459.10948.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00413.txt.bz2 > From: Pedro Alves > Date: Fri, 19 Sep 2008 14:59:10 +0100 > Cc: gdb-patches@sourceware.org > > > This looks otherwise OK (though I don't understand when you use > > add_inferior vs add_inferior_silent). > > Hmmm, the initial thought was somewhat similar to the > use of add_thread_silent in targets that didn't add the main thread > to the list because they don't support multi-threads. (monitor, > remote-sim). As in, don't emit a CLI note notification if > the target pid was made up by GDB and thus should not be visible > to the user, and emit if otherwise. This one seems to have been > missed by that logic. > > But I agree that this sounds somewhat bogus. It should be the > the target that should decide what to print... I'll need > to do a few further adjustments for that to be possible > though. These CLI notifications are off by default, so we > can either get rid of add_inferior_silent, or make > go32-nat.c also use it. Any preference? The attached does > the latter. I prefer the way of letting the target decide what to print. Can we do that?