Re: [PATCH] Doco for GDB/MI

Eli Zaretskii
2006-02-09T22:21:07Z

> From: Nick Roberts <nickrob@snap.net.nz>
> Date: Fri, 10 Feb 2006 10:51:38 +1300
>
> This patch reflects recent changes in MI output due to fullname being added to
> print_one_breakpoint (-break-insert and -break-info use this command too.),
> adds the times field where needed, corrects a couple of typos, updates the
> general form given for output of -break-insert (very out of date) and
> abbreviates some unnecessarily long fullnames.

Thanks.

> OK to commit?

Yes, after you take care of the following gotchas:

> ! ^done,bkpt=@{number="1",addr="0x000100d0",file="hello.c",fullname="/home/foo/hello.c",line="5",times="0"@}

This is too long, even for @smallexample. Please break it into two
lines.

> ! addr="0x000100d0",func="main",file="hello.c",fullname="/home/foo/hello.c",line="5",times="0",ignore="3"@}]@}

Same here. (There are more too-long examples like this.)

> ! fullname="@var{full filename}",line="@var{lineno}",times="@var{times}"@}

Arguments in @var should not have embedded whitespace.