From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-42787-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5610 invoked by alias); 9 Feb 2006 22:21:07 -0000
Received: (qmail 5595 invoked by uid 22791); 9 Feb 2006 22:21:04 -0000
X-Spam-Check-By: sourceware.org
Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 09 Feb 2006 22:21:03 +0000
Received: from HOME-C4E4A596F7 (IGLD-84-228-240-137.inter.net.il [84.228.240.137]) 	by romy.inter.net.il (MOS 3.7.3-GA) 	with ESMTP id DNP40285 (AUTH halo1); 	Fri, 10 Feb 2006 00:20:58 +0200 (IST)
Date: Thu, 09 Feb 2006 22:21:00 -0000
Message-Id: <u4q3841iq.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Nick Roberts <nickrob@snap.net.nz>
CC: gdb-patches@sourceware.org
In-reply-to: <17387.47466.567939.339554@kahikatea.snap.net.nz> (message from 	Nick Roberts on Fri, 10 Feb 2006 10:51:38 +1300)
Subject: Re: [PATCH] Doco for GDB/MI
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <17387.47466.567939.339554@kahikatea.snap.net.nz>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-02/txt/msg00225.txt.bz2

> From: Nick Roberts <nickrob@snap.net.nz>
> Date: Fri, 10 Feb 2006 10:51:38 +1300
> 
> This patch reflects recent changes in MI output due to fullname being added to
> print_one_breakpoint (-break-insert and -break-info use this command too.),
> adds the times field where needed, corrects a couple of typos, updates the
> general form given for output of -break-insert (very out of date) and
> abbreviates some unnecessarily long fullnames.

Thanks.

> OK to commit?

Yes, after you take care of the following gotchas:

> ! ^done,bkpt=@{number="1",addr="0x000100d0",file="hello.c",fullname="/home/foo/hello.c",line="5",times="0"@}

This is too long, even for @smallexample.  Please break it into two
lines.

> ! addr="0x000100d0",func="main",file="hello.c",fullname="/home/foo/hello.c",line="5",times="0",ignore="3"@}]@}

Same here.  (There are more too-long examples like this.)

> ! fullname="@var{full filename}",line="@var{lineno}",times="@var{times}"@}

Arguments in @var should not have embedded whitespace.