Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Docs and NEWS for breakpoint changes
Date: Thu, 27 Sep 2007 20:49:00 -0000	[thread overview]
Message-ID: <u4phf6dh8.fsf@gnu.org> (raw)
In-Reply-To: <200709272227.34355.vladimir@codesourcery.com> (message from 	Vladimir Prus on Thu, 27 Sep 2007 22:27:34 +0400)

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Thu, 27 Sep 2007 22:27:34 +0400
> Cc: gdb-patches@sources.redhat.com
> 
> > > +pending breakpoint that never had its address known,
> > 
> > I think this is better:
> > 
> >   For a pending address whose address is not yet known,
> 	          ^^^^^^^
> 
> Did you mean "breakpoint" instead of first "address"?

Yes, sorry.

> > Example, please.  A picture is worth a thousand words.
> 
> I've added one. Is example with a line as long as 75 characters OK?

@smallexample can handle this (which is why we use it instead of
@example).

> Thanks for review. I attach the revised version.

It's fine, except for a few small gotchas:

> +It is possible that a breakpoints correspond to several locations 
                       ^^^^^^^^^^^^^^^^^^^^^^^^
"a breakpoint corresponds".

> +For a C@t{++} constructor, the gcc compiler generates several
                                  ^^^
You forgot to replace with @value{NGCC}.

> +by one row for each breakpoint location. The header row
                                          ^^
Still only one space.

> +any shared library is loaded or unloaded. Typically, you would
                                           ^^
And here.


  reply	other threads:[~2007-09-27 20:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-26 18:07 Vladimir Prus
2007-09-26 21:13 ` Eli Zaretskii
2007-09-27 18:27   ` Vladimir Prus
2007-09-27 20:49     ` Eli Zaretskii [this message]
2007-09-28  6:36       ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u4phf6dh8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox