From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30954 invoked by alias); 31 Oct 2007 20:41:02 -0000 Received: (qmail 30871 invoked by uid 22791); 31 Oct 2007 20:41:01 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 31 Oct 2007 20:40:59 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-229-212-193.inter.net.il [84.229.212.193]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id JGU42767 (AUTH halo1); Wed, 31 Oct 2007 22:40:04 +0200 (IST) Date: Wed, 31 Oct 2007 21:35:00 -0000 Message-Id: From: Eli Zaretskii To: Daniel Jacobowitz CC: gdb-patches@sourceware.org In-reply-to: <20071029203042.GA26597@caradoc.them.org> (message from Daniel Jacobowitz on Mon, 29 Oct 2007 16:30:42 -0400) Subject: Re: [rfc] Remote file transfer support Reply-to: Eli Zaretskii References: <20071029203042.GA26597@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00873.txt.bz2 > Date: Mon, 29 Oct 2007 16:30:42 -0400 > From: Daniel Jacobowitz > > 2007-10-29 Daniel Jacobowitz > > * gdb.texinfo (Remote Debugging): Add File Transfer section. > (Remote Configuration): Document Host I/O packets. > (GDB/MI): Add GDB/MI File Transfer Commands section. > (Remote Protocol): Add Host I/O Packets section. > (Packets): Add vFile. I have a few comments for this part. > +@node File Transfer > +@section Sending files to a remote system > +@cindex remote target, file transfer > +@cindex file transfer Please add a @cindex entry as follows: @cindex sending files to remote systems > +for targets accessible through other means, e.g.@: GNU/Linux systems ^^^^^^^^^ I believe we want to use @sc{gnu}/Linux. > +@item remote put @var{hostfile} @var{targetfile} > +Copy @var{hostfile} from the host system (the machine running > +@value{GDBN}) to the path @var{targetfile} on the target system. GNU coding conventions frown on using "path" in the sense of a file name or a fully qualified directory name. "Path" is reserved for $PATH and other lists of directories, like the value of $MANPATH etc. Also, I think it would help to say "file" at least once, to make sure the reader understands that @var{hostfile} and other similar parameters are file names: Copy file @var{hostfile} from the host system ... > +Perform a file operation on the target system. For details, > +@xref{Host I/O Packets}. @xref produces "See", with a capital `S', which looks as a typo in the middle of a sentence. To avoid this, use @ref as follows: For details, see @ref{Host I/O Packets}. or reverse the order: @xref{Host I/O Packets}, for details. > The protocol has some common features with the File-I/O > +protocol, e.g.@: all constants and data structures are encoded in the > +same way. I didn't understand this sentence. Can you explain what does it mean to say? > However, the packets are structured differently, because > +requests are initiated by @value{GDBN}, and the target's memory is not > +involved. This is also unclear. > For > +operations which return data, @var{attachment} will be provided a > +binary buffer. Did you mean "as a binary buffer", perhaps? > +The data read should be returned as a binary attachment on success, > +even if zero bytes were read. Ehm... how do you express a buffer of zero bytes? > --- gdb/NEWS.orig 2007-10-29 15:20:55.000000000 -0400 > +++ gdb/NEWS 2007-10-29 16:11:11.000000000 -0400 This part is fine with me. Thanks.