From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5721 invoked by alias); 15 Feb 2008 08:39:14 -0000 Received: (qmail 5704 invoked by uid 22791); 15 Feb 2008 08:39:13 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 15 Feb 2008 08:38:54 +0000 Received: from HOME-C4E4A596F7 (IGLD-83-130-247-140.inter.net.il [83.130.247.140]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id KFS99703 (AUTH halo1); Fri, 15 Feb 2008 10:38:12 +0200 (IST) Date: Fri, 15 Feb 2008 08:39:00 -0000 Message-Id: From: Eli Zaretskii To: Nick Roberts CC: brobecker@adacore.com, ghost@cs.msu.su, gdb-patches@sourceware.org In-reply-to: <18357.3708.628053.809241@kahikatea.snap.net.nz> (message from Nick Roberts on Fri, 15 Feb 2008 17:01:00 +1300) Subject: Re: (gdb-6.8) Discard breakpoint address if shared library is unloaded Reply-to: Eli Zaretskii References: <20080204214226.GF20922@adacore.com> <20080207063817.GA3907@adacore.com> <18347.45621.630420.453287@kahikatea.snap.net.nz> <200802080942.29622.ghost@cs.msu.su> <18348.1691.478013.310214@kahikatea.snap.net.nz> <20080214214246.GC3713@adacore.com> <18357.3708.628053.809241@kahikatea.snap.net.nz> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00247.txt.bz2 > From: Nick Roberts > Date: Fri, 15 Feb 2008 17:01:00 +1300 > Cc: Vladimir Prus , gdb-patches@sourceware.org > > *** breakpoint.c 15 Feb 2008 16:52:37 +1300 1.302 > --- breakpoint.c 15 Feb 2008 16:55:43 +1300 > *************** print_one_breakpoint_location (struct br > *** 3426,3448 **** > /* 4 */ > annotate_field (3); > if (part_of_multiple) > ! ui_out_field_string (uiout, "enabled", > ! loc->shlib_disabled > ! ? (loc->enabled ? "y(p)" : "n(p)") > ! : (loc->enabled ? "y" : "n")); > else > ! { > ! int pending = (b->loc == NULL || b->loc->shlib_disabled); > ! /* For header of multiple, there's no point showing pending > ! state -- it will be apparent from the locations. */ > ! if (header_of_multiple) > ! pending = 0; > ! ui_out_field_fmt (uiout, "enabled", "%c%s", > ! bpenables[(int) b->enable_state], > ! pending ? "(p)" : ""); > ! if (!pending) > ! ui_out_spaces (uiout, 3); > ! } > > > /* 5 and 6 */ > --- 3426,3436 ---- > /* 4 */ > annotate_field (3); > if (part_of_multiple) > ! ui_out_field_string (uiout, "enabled", loc->enabled ? "y" : "n"); > else > ! ui_out_field_fmt (uiout, "enabled", "%c", > ! bpenables[(int) b->enable_state]); > ! ui_out_spaces (uiout, 2); > > > /* 5 and 6 */ > *************** print_one_breakpoint_location (struct br > *** 3553,3562 **** > if (addressprint) > { > annotate_field (4); > ! if (b->loc == NULL) > ! ui_out_field_string (uiout, "addr", ""); > ! else if (header_of_multiple) > ui_out_field_string (uiout, "addr", ""); > else > ui_out_field_core_addr (uiout, "addr", loc->address); > } > --- 3541,3550 ---- > if (addressprint) > { > annotate_field (4); > ! if (header_of_multiple) > ui_out_field_string (uiout, "addr", ""); > + if (b->loc == NULL || loc->shlib_disabled) > + ui_out_field_string (uiout, "addr", ""); > else > ui_out_field_core_addr (uiout, "addr", loc->address); > } > *************** breakpoint_1 (int bnum, int allflag) > *** 3781,3787 **** > ui_out_table_header (uiout, 4, ui_left, "disp", "Disp"); /* 3 */ > if (nr_printable_breakpoints > 0) > annotate_field (3); > ! ui_out_table_header (uiout, 4, ui_left, "enabled", "Enb"); /* 4 */ > if (addressprint) > { > if (nr_printable_breakpoints > 0) > --- 3769,3775 ---- > ui_out_table_header (uiout, 4, ui_left, "disp", "Disp"); /* 3 */ > if (nr_printable_breakpoints > 0) > annotate_field (3); > ! ui_out_table_header (uiout, 3, ui_left, "enabled", "Enb"); /* 4 */ > if (addressprint) > { > if (nr_printable_breakpoints > 0) This will require a suitable change to the manual, right?