From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3842 invoked by alias); 28 Apr 2008 18:52:57 -0000 Received: (qmail 3832 invoked by uid 22791); 28 Apr 2008 18:52:56 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 28 Apr 2008 18:52:37 +0000 Received: from HOME-C4E4A596F7 ([84.229.228.217]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K0100FN3UET3KL0@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Mon, 28 Apr 2008 22:06:50 +0300 (IDT) Date: Tue, 29 Apr 2008 00:40:00 -0000 From: Eli Zaretskii Subject: Re: Fwd: [RFA] new command to search memory In-reply-to: X-012-Sender: halo1@inter.net.il To: Doug Evans Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: Content-transfer-encoding: 7BIT References: <20080214021915.F3FE51C72F0@localhost> <20080226022335.GB4456@caradoc.them.org> <20080229031252.GA2897@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00640.txt.bz2 > Date: Mon, 28 Apr 2008 07:06:51 -0700 > From: "Doug Evans" > > --- NEWS 4 Apr 2008 15:51:15 -0000 1.264 > +++ NEWS 17 Apr 2008 02:35:23 -0000 This part is okay, thanks. > + printf_filtered (_("empty search range\n")); Do we want to capitalize the messages (here and elsewhere in your patch)? > --- doc/gdb.texinfo 16 Apr 2008 13:14:18 -0000 1.481 > +++ doc/gdb.texinfo 17 Apr 2008 02:35:24 -0000 This part is also okay, but I have a few comments/corrections. > +@table @code > +@item b > +Bytes. > +@item h > +Halfwords (two bytes). > +@item w > +Words (four bytes). > +@item g > +Giant words (eight bytes). > +@end table In this table, the text under @item's are not complete sentences, so it's better to start them with a lowercase letter and not end them with a period. > +This means, for example, that if the current source language is C/C++ Please use C@t{++} for "C++", it looks better in print. > +then searching for the string "hello" includes the trailing '\0'. Please quote text ``like this'', rather than "like this", it looks better in print (and will be translated into "like this" in the on-line manual). > +Note that this means, for example, that in the case of C-like languages > +a search for an untyped 0x42 will search for "(int) 0x42" Please use @samp{(int) 0x42}, to force use of typeface appropriate for program symbols. > +@item @var{n}, maximum number of finds > +The maximum number of finds to print. The default is to print all finds. I think "matches" is a better word than "finds". > +Strings may be specified for search values, quote them with double-quotes It's better to avoid passive tense. For example: You can use strings as search values. Quote them with double-quotes (@code{"}). > +For example, if stopped at the printf in this function: "printf" should be in @code. > +@smallexample > +void > +hello () > +@{ > + static char hello[] = "hello-hello"; > + static struct @{ char c; short s; int i; @} __attribute__ ((packed)) mixed This last line is too long for a @smallexample. Please break it into two shorter lines. > +You get during debugging: This is a continuation of the sentence broken by @smallexample. So you should begin it with a lower-case `y', and you should put @noindent (on a line of itself) immediately before it, to prevent indentation that is typically output at the beginning of a paragraph. Other than that, your changes for the documentation are okay with me. Thanks!