From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18427 invoked by alias); 5 Jul 2005 20:03:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18349 invoked by uid 22791); 5 Jul 2005 20:03:32 -0000 Received: from legolas.inter.net.il (HELO legolas.inter.net.il) (192.114.186.24) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 05 Jul 2005 20:03:32 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-228-245-33.inter.net.il [84.228.245.33]) by legolas.inter.net.il (MOS 3.5.8-GR) with ESMTP id EVB83833 (AUTH halo1); Tue, 5 Jul 2005 23:02:32 +0300 (IDT) Date: Tue, 05 Jul 2005 20:03:00 -0000 Message-Id: From: Eli Zaretskii To: Mark Kettenis CC: gdb-patches@sourceware.org In-reply-to: <200507050728.j657SueI005195@jop31.nfra.nl> (message from Mark Kettenis on Tue, 5 Jul 2005 09:28:56 +0200) Subject: Re: [commit] Properly cast sentinels for concat() Reply-to: Eli Zaretskii References: <200507041336.j64Da5cE001221@jop31.nfra.nl> <20050704225153.GA31424@nevyn.them.org> <200507050728.j657SueI005195@jop31.nfra.nl> X-SW-Source: 2005-07/txt/msg00065.txt.bz2 > Date: Tue, 5 Jul 2005 09:28:56 +0200 > From: Mark Kettenis > CC: gdb-patches@sourceware.org > > But in Mark's case, NULL is defined as (void *)0, so it's a pointer, > not an int. > > No it isn't, OpenBSD has > > #define NULL 0L Sorry, I got confused: you did mention `void *', but that was about the GCC version of stddef.h. > Not that I think that it is a good thing, but Andrew has been talking > about making GDB compilable with a C++ compiler before. I never understood why we should waste any efforts on that. > Do you still want me to revert the patch? Well, let's say that I dislike those casts very much. So if there's any reasonable chance to get the maintainers of OpenBSD and the OpenBSD GCC port to fix this problem in the forseeble future, I'd suggest to revert it. If not, I'll yield.