From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24400 invoked by alias); 20 Jul 2006 19:38:24 -0000 Received: (qmail 24384 invoked by uid 22791); 20 Jul 2006 19:38:22 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Jul 2006 19:38:19 +0000 Received: from HOME-C4E4A596F7 (IGLD-83-130-247-14.inter.net.il [83.130.247.14]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id FHZ88860 (AUTH halo1); Thu, 20 Jul 2006 22:38:15 +0300 (IDT) Date: Thu, 20 Jul 2006 19:38:00 -0000 Message-Id: From: Eli Zaretskii To: Vladimir Prus CC: gdb-patches@sources.redhat.com In-reply-to: <200607201342.30712.vladimir@codesourcery.com> (message from Vladimir Prus on Thu, 20 Jul 2006 13:42:30 +0400) Subject: Re: Flash support part 2: flash programming Reply-to: Eli Zaretskii References: <200607201342.30712.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00276.txt.bz2 > From: Vladimir Prus > Date: Thu, 20 Jul 2006 13:42:30 +0400 > > +/* Calls the first non-null to_flash_done pointer in target_stack. */ > +void target_flash_done (); Should this be a full prototype, including the parameters? > +target_write_memory_blocks (VEC(memory_write_request) *memory_write_requests, > + int (*flash_write_allowed)(), > + enum flash_preserve_mode (*preserve_flash)(), And the same for these two. > + error(_("Flash region erased by not written")); Did you maybe mean "... BUT not written"? If not, I cannot parse this message.