From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14568 invoked by alias); 1 Apr 2008 03:28:33 -0000 Received: (qmail 14559 invoked by uid 22791); 1 Apr 2008 03:28:32 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (213.8.233.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 01 Apr 2008 03:28:08 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-21-134.inter.net.il [80.230.21.134]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id FJW90605 (AUTH halo1); Tue, 1 Apr 2008 06:27:57 +0300 (IDT) Date: Tue, 01 Apr 2008 13:23:00 -0000 Message-Id: From: Eli Zaretskii To: Daniel Jacobowitz CC: gdb-patches@sourceware.org In-reply-to: <20080331221024.GA22334@caradoc.them.org> (message from Daniel Jacobowitz on Mon, 31 Mar 2008 18:10:24 -0400) Subject: Re: [RFC 2/5] Frame unwinding using struct value Reply-to: Eli Zaretskii References: <20080331221024.GA22334@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00005.txt.bz2 > Date: Mon, 31 Mar 2008 18:10:24 -0400 > From: Daniel Jacobowitz > > 2008-03-31 Daniel Jacobowitz > > * gdbint.texinfo (Stack Frames): New chapter. > (Algorithms): Move Frames text to the new chapter. > (Target Conditionals): Delete SAVE_DUMMY_FRAME_TOS. Document > gdbarch_dummy_id instead of gdbarch_unwind_dummy_id. Thanks, this part is approved, but I have some comments: > +@node Stack Frames > +@chapter Stack Frames > + > +@cindex frame > +@cindex call stack frame > +A frame is a construct that @value{GDBN} uses to keep track of calling > +and called functions. > + > +@cindex frame, unwind It is not useful to have several index entries that begin with the same string and point to the same page. So I suggest to replace the last one with "@cindex unwind frame". > +Developers wishing to learn more about unwinders, are encouraged to > +read the @sc{dwarf} specification. How about a pointer to the DWARF Spec here? > +is a sentinel frame, then @code{get_frame_type (@var{f}) == > +SENTINEL_FRAME}. I would use @equiv{} here, of even @expansion{}, instead of a literal "==". > +@section Selecting an Unwinder Is it a good idea to have a section without a node? > +The architecture registers a list of frame unwinders (@code{struct > +frame_unwind}), using the functions > +@code{frame_unwind_prepend_unwinder} and > +@code{frame_unwind_append_unwinder}. Each unwinder includes a Please add an @findex entry for each function you mention. > +The returned value must have the same type as the register. It may > +have any lval type. I think we should say "lvalue" here, not "lval". > +Same as @code{frame_unwind_got_constant}, excep that the value is a target ^^^^^ A typo.