From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23747 invoked by alias); 8 Aug 2008 08:01:30 -0000 Received: (qmail 23737 invoked by uid 22791); 8 Aug 2008 08:01:29 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout5.012.net.il (HELO mtaout5.012.net.il) (84.95.2.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 08 Aug 2008 08:00:50 +0000 Received: from HOME-C4E4A596F7 ([84.229.211.50]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K5900LZQVLQOVK0@i_mtaout5.012.net.il> for gdb-patches@sourceware.org; Fri, 08 Aug 2008 11:01:03 +0300 (IDT) Date: Fri, 08 Aug 2008 08:01:00 -0000 From: Eli Zaretskii Subject: Re: go32-nat, always a thread In-reply-to: <200808080439.17254.pedro@codesourcery.com> X-012-Sender: halo1@inter.net.il To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: <200808080439.17254.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00188.txt.bz2 > From: Pedro Alves > Date: Fri, 8 Aug 2008 04:39:17 +0100 > > This patch makes the go32 (djgpp) target always register the main thread > in GDB's thread table. What do we need this for? DJGPP doesn't support threading; the ptid_t variables in go32-nat.c are simply dummies devised to make the compiler happy because go32-nat.c uses interfaces that pass thread IDs. But there's no infrastructure behind this farce. The code you added will now cause all kinds of notifications, like "thread started", be displayed, which is just confusing when the programmer knows there're no threads. Is this really justified? > Anyone able to test this? Eli? It's been a while since I built the DJGPP port, so I will probably need a good vacation to do that again. But let's first decide if this change is really necessary.