From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-60278-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31607 invoked by alias); 24 Nov 2008 21:19:05 -0000
Received: (qmail 31533 invoked by uid 22791); 24 Nov 2008 21:19:04 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout3.012.net.il (HELO mtaout3.012.net.il) (84.95.2.7)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Nov 2008 21:18:08 +0000
Received: from conversion-daemon.i_mtaout3.012.net.il by i_mtaout3.012.net.il (HyperSendmail v2004.12) id <0KAU00F00WL1HT00@i_mtaout3.012.net.il> for gdb-patches@sources.redhat.com; Mon, 24 Nov 2008 23:19:59 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.168.41]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KAU004VCWLAE3E1@i_mtaout3.012.net.il>; Mon, 24 Nov 2008 23:19:59 +0200 (IST)
Date: Tue, 25 Nov 2008 02:41:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] -list-target-groups --available
In-reply-to: <ud4gkj3bc.fsf@gnu.org>
X-012-Sender: halo1@inter.net.il
To: vladimir@codesourcery.com, drow@false.org, gdb-patches@sources.redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <u3ahgj01j.fsf@gnu.org>
References: <200811142003.33600.vladimir@codesourcery.com> <20081120144226.GA9855@caradoc.them.org> <200811221938.51061.vladimir@codesourcery.com> <ud4gkj3bc.fsf@gnu.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00669.txt.bz2

> Date: Mon, 24 Nov 2008 22:07:19 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: drow@false.org, gdb-patches@sources.redhat.com
> 
> > From: Vladimir Prus <vladimir@codesourcery.com>
> > Date: Sat, 22 Nov 2008 19:38:50 +0300
> > Cc: gdb-patches@sources.redhat.com
> > 
> > This version has DTD. It also has documentation -- Eli, can you review it.
> 
> I will, in a few days.

Actually, it is small enough to review now.

> +@node Operating System Information
> +@appendix Operating System Information
> +@cindex operating system information
> + [...]
> +@node Process list
> +@section Process list

I take it that this last @node is supposed to be a sub-node of
"Operating System Information", right?  If so, there are 2 problems
here:

  . @appendix is an equivalent of @section, so its immediate sub-nodes
    cannot be @section's.  They should be @appendixsubsec instead.

  . There should be a @menu in the parent @node that lists all its
    immediate sub-nodes.  Otherwise, makeinfo will barf or do the
    wrong thing, because it will not be able to intuit the correct
    node structure of the document.


> +Each item is required to include a column with name of @samp{pid},
> +that identifies the process.

"name of `pid'" does not sound right.  Do you mean " the name of the
process identified by @var{pid}"?

> +                            The @samp{user} and @samp{command}
> +columns may be provided

  "The @samp{user} and @samp{command} columns are optional..."

> +Target may provide additional columns, but no processing of them
> +is performed by the current version of @value{GDBN}.

Too much passive tense.  Suggest to rephrase:

  Target may provide additional columns which @value{GDBN} currently
  ignores.

Thanks.