From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-51906-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22637 invoked by alias); 1 Nov 2007 04:11:03 -0000
Received: (qmail 22628 invoked by uid 22791); 1 Nov 2007 04:11:02 -0000
X-Spam-Check-By: sourceware.org
Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (213.8.233.22)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 01 Nov 2007 04:11:00 +0000
Received: from HOME-C4E4A596F7 (IGLD-84-229-254-154.inter.net.il [84.229.254.154]) 	by nitzan.inter.net.il (MOS 3.7.3a-GA) 	with ESMTP id IEX23397 (AUTH halo1); 	Thu, 1 Nov 2007 06:08:07 +0200 (IST)
Date: Thu, 01 Nov 2007 04:11:00 -0000
Message-Id: <u1wbar4fv.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: luisgpm@linux.vnet.ibm.com
CC: gdb-patches@sourceware.org
In-reply-to: <1193879919.4994.2.camel@localhost> (message from Luis Machado on 	Wed, 31 Oct 2007 22:18:39 -0300)
Subject: Re: [PATCH] printf support for DFP values
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <1193449497.6950.22.camel@localhost> <ubqaksyin.fsf@gnu.org> 	 <1193669215.4800.10.camel@localhost> <ur6jdr8iy.fsf@gnu.org> 	 <20071029201252.GA21583@caradoc.them.org> <upryxqmb5.fsf@gnu.org> 	 <ulk9lqlmm.fsf@gnu.org> <1193753649.4283.5.camel@localhost> 	 <uir4oqs3w.fsf@gnu.org> <1193879919.4994.2.camel@localhost>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-11/txt/msg00002.txt.bz2

> From: Luis Machado <luisgpm@linux.vnet.ibm.com>
> Cc: gdb-patches@sourceware.org
> Date: Wed, 31 Oct 2007 22:18:39 -0300
> 
> How does this manual entry look? I tried to make it clear, but if i
> missed something please let me know.

It's okay, modulo the following problems:

> +Printf also supports conversion specifications for DFP (Decimal Floating Point)
> +types using the following conversion letters:

"Printf" is a name of a command, so please use @code{Printf}.

Also, when you first introduce a term, such as DFP, it is good to put
it in @dfn{}, as in @dfn{Decimal Floating Point}, so that it stands
out.

> +Printing DFP types with the conversion letters seen before works as
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +the example:

"with the above conversion letters" is better.

Also, I'd rephrase this:

 Here's an example of printing DFP types using the above conversion
 letters:

Other than that, the patch for the manual is fine.  Thanks.