From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22363 invoked by alias); 1 Dec 2007 20:59:06 -0000 Received: (qmail 22355 invoked by uid 22791); 1 Dec 2007 20:59:05 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (213.8.233.22) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 01 Dec 2007 20:58:58 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-228-57.inter.net.il [80.230.228.57]) by nitzan.inter.net.il (MOS 3.7.3a-GA) with ESMTP id ILM11808 (AUTH halo1); Sat, 1 Dec 2007 22:56:07 +0200 (IST) Date: Sat, 01 Dec 2007 20:59:00 -0000 Message-Id: From: Eli Zaretskii To: Vladimir Prus CC: gdb-patches@sources.redhat.com In-reply-to: <200712011911.31082.vladimir@codesourcery.com> (message from Vladimir Prus on Sat, 1 Dec 2007 19:11:30 +0300) Subject: Re: [RFC] Keep breakpoints always inserted. Reply-to: Eli Zaretskii References: <200712011423.21957.vladimir@codesourcery.com> <200712011911.31082.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00027.txt.bz2 > From: Vladimir Prus > Date: Sat, 1 Dec 2007 19:11:30 +0300 > Cc: gdb-patches@sources.redhat.com > > > Please also consider whether something in gdbint.texinfo needs to be > > updated as result of this change (unless you already considered that). > > I did not, yet. What would be good to add there? I don't really know: I didn't have enough time to read your patch carefully. I just noticed that you said "This patch makes breakpoint always inserted", and thought that gdbint.texinfo might tell we remove breakpoints on each target stop and re-insert them before each resume. "Always inserted" sounded like it invalidates this model, does it? > The basic design principle that all changes to breakpoints are > routed through a single function that then handles > inserting/removing locations probably should be added. Yes, that too. Thanks.