From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95065 invoked by alias); 24 Mar 2018 10:41:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95053 invoked by uid 89); 24 Mar 2018 10:41:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-27.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=pls, HSensitivity:Normal X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.17.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 24 Mar 2018 10:41:51 +0000 Received: from [165.120.72.254] ([165.120.72.254]) by 3c-app-mailcom-bs13.server.lan (via HTTP); Sat, 24 Mar 2018 11:41:47 +0100 MIME-Version: 1.0 Message-ID: From: "Game Debugger" To: "gdb patches" Subject: patch for search bug in gdbserver Content-Type: text/plain; charset=UTF-8 Date: Sat, 24 Mar 2018 10:41:00 -0000 Sensitivity: Normal X-UI-Out-Filterresults: notjunk:1;V01:K0:QAJ8Xj8yYPo=:RUgKCP0EmvOnjzRhWRUVvm 9lyWvCBuWRF3lLGp+5uwleW9ekwTG8uBCaczgne0QvAu5DyemB+GTURa+jgtggzmQwaz/VONb 77XONmJHfzBcUovLXQfubaLOQ4MZ/zmkB6W72o0Q5XRB8KrD9+2B7xz79uhHIWTlctoQgREi6 ThqDcC9MoOp5yFSONMmfQYcWhS/VTf3Q5EL3GJo4z9ZtlB2PXbvwZxzQSq7YFjTMQpaCkXCwZ /qsbnkiVVUthfxbmLSuE3ypeMyevh0jh80TFZTLcznQtUMymIDD/ZOPoVvGjvcmB0d6U+zxy8 GY92i35dhM9IYyTdZe+t7CT6weRxs0YHV4m/mtM+eVhQTgaiFpd+Xo0W6dauEClIxIUPuXyjk Bjc7O0z/sWlYZh7wI7s9xwQFPhQ8QhHCLaUqcaE0/72tz8Rqx8B6r+EUWOJrgcJAWq3DCkcc9 Q/Yf6freVePJrF9Cu2FCMsWjmQoo+usH3OOe+zdCKKIOqqUc5KpA X-SW-Source: 2018-03/txt/msg00480.txt.bz2 $greeting$ found while trying to search memory via gdbserver it just doesn't work except when target pattern is in the first block read patch was obvious once i dug into the code; and is tested looks like original bug was a copy and paste error from top of loop pls let me know if you ise it ty $name$ ============= PATCH FOLLOWS diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c index 64c72bd..943dfb2 100644 --- a/gdb/gdbserver/server.c +++ b/gdb/gdbserver/server.c @@ -1123,7 +1123,7 @@ handle_search_memory_1 (CORE_ADDR start_addr, CORE_ADDR search_space_len, : chunk_size); if (gdb_read_memory (read_addr, search_buf + keep_len, - nr_to_read) != search_buf_size) + nr_to_read) != nr_to_read) { warning ("Unable to access %ld bytes of target memory " "at 0x%lx, halting search.", =============== PATCH FINISHED :) $signature$