From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4BrHEG9rYmewByAAWB0awg (envelope-from ) for ; Wed, 18 Dec 2024 01:27:59 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=M4bDmh35; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 417451E097; Wed, 18 Dec 2024 01:27:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EB76A1E05C for ; Wed, 18 Dec 2024 01:27:58 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8F9953858416 for ; Wed, 18 Dec 2024 06:27:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8F9953858416 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=M4bDmh35 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by sourceware.org (Postfix) with ESMTPS id C82003858C54 for ; Wed, 18 Dec 2024 06:27:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C82003858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C82003858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::733 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734503245; cv=none; b=JebWxFoLb2166C7/nYi4tGcuGf1VzvcXoYfa0k8QLUuE0R1iZE5x5iap5vzdVI0FOnLmJ6jGfq4VnTcH641+PmrVzmXUqog4qTooe/WDpanjMLReHBiwWb8aNYhtpQ/qGw8FhGtjAUgL1Wbs3iLjzgRirVIfwOh4NYXuqC3u3KY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734503245; c=relaxed/simple; bh=Z/VUYBk2xKgTntaGZ5K/yODyBIIxh6bydZDbwp8RVUo=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=nIXRHNzwD/yRDwxV1wGs3WVBKiY91w55KWXE5+IU+sygR9BDhwqvCQYvR/uhG+qoZ8ufPTBmuTkqSa0JbXieh31GIvkiTyk+YQjKJ6DiSXUbE7pH+8dq6ZchWSn10Njx7JghKH+l3o9V4UUbp+Zn6uSrtWWo4aqLa09bnol77yY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C82003858C54 Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-7b6e9317a2aso37091885a.0 for ; Tue, 17 Dec 2024 22:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734503244; x=1735108044; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=v25Xlmc53OIHj/2VBj2NFLnPVUMc8NyHUpzMnUqmUB8=; b=M4bDmh351J0KyzEF+y+yKOAKPva8CTafrla7hGuSIzhFSiU6kaSIBfcXf7fKfG9AeJ upTYNlvrdMAY5pVeZofdPM9VGtl5SYK2pzk50XeO9Ab9bFc0aS3vfzDM20/hF+NwLGuQ ULPdVWp5ro5djQg2QX5D/FcgNm4up32w3a7uxHcyZcm0spdnJPrIDToWbNBqtUrKmQsN e4MD6/TBPbuzTFLf1tqiUskMWLRqwh+0MKCs8Qz4BR5oWTnr2X1zWGrzXhit/57bM9ZW hDLV9IZp2Rnc6XFunFT8jwvuNMwiX44WuGlZcKeDKbrJ91aV3d8dMBnYVHtvTN4TI6L1 6qAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734503244; x=1735108044; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v25Xlmc53OIHj/2VBj2NFLnPVUMc8NyHUpzMnUqmUB8=; b=I3xllfCSzMeMEd9xveWQ35nRHdDqikTZz4ZsD16z0nH4dg9n+3/XfPkwVpgrUFlkhj g4D0SphHQ95nAuQkuxcuXI73DjMj7coAZQZoRqge1IPYRIHFC6N1kBwJqsWFnFCuJF7E KpDOQquYrpQXvBX6mbjNTnPL0lVjKEmWNrDf6kPB725r3Y3e9DmZoxYPEVYPlGq7Fwv8 NtI3N1CQAH1W7sl+7tH5AYxE+8UDiBR87YBTHgyYKhKUqz56fGn9NHIZ2v0TXSdOJnFl rFjK2xyQYJmCvDe5W3TdFk+rac212te2ijQI7UsxWFzbf8EePpXqezI+jlaAcm13Lpfh 9VaA== X-Gm-Message-State: AOJu0YxdNXHA/oqpu2nvS5GKrd8Mawc8zZJYrvfWBxH+yN5BfYff5QWP lq3DCF/rwnT+TFCwUkcGaZM0gc+rqo1cLYuaY00cjDBed8vA3d9BqCxPMCQ= X-Gm-Gg: ASbGnctptZJqEBiZ4naiqAZHciy+jR6bfoGDaTnSPFKyXyLNK6dsD+ZUeC9OmSR5dU7 VeDoTKfao4B4MYjLwyWkOMgXWPqKaRLSp2uGRnp1R0vP7PUXrE72Uy4T8ifGisj6n3K81WQRRRd 7D5sE2xDH0w3b9rMp4Yhwie2mbegERr1duIujSSXGgC1Zbf2xdGGANaffZDCRBeRggkGcB7dgcr gYsWDRVh4cu2sfHEbvH548O6bEF5GHPpvO9FXBwGUqoDgvBbG1gRRi+LZxzI8j7yRoTXxSJ6iI3 pLIGfxPuDyanD/6RzNBnamJsRUs= X-Google-Smtp-Source: AGHT+IHC3KzCdyNxKsr8v07ldobJ5P+Iyc4XSJBf0PgrsrHNqSBsOZExaiRrBbJve6PpG213RPboEg== X-Received: by 2002:a05:6214:d6a:b0:6d4:ac4:c1cd with SMTP id 6a1803df08f44-6dd099affe3mr22915096d6.8.1734503244274; Tue, 17 Dec 2024 22:27:24 -0800 (PST) Received: from localhost (dynamic-acs-24-144-188-205.zoominternet.net. [24.144.188.205]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dccd257d56sm46789186d6.50.2024.12.17.22.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 22:27:23 -0800 (PST) Date: Wed, 18 Dec 2024 01:27:19 -0500 From: Flavio Cruz To: gdb-patches Cc: Tom Tromey Subject: [PATCH] Hurd: remove VLA usage. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Compilation will fail with -Werror=vla, which seems to be the default. Note that we can allocate just an array of num_threads pointers, hence the change. --- gdb/gnu-nat.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c index a8a4da1c..60819695 100644 --- a/gdb/gnu-nat.c +++ b/gdb/gnu-nat.c @@ -1016,14 +1016,14 @@ gnu_nat_target::inf_validate_procs (struct inf *inf) { /* Make things normally linear. */ mach_msg_type_number_t search_start = 0; - /* Which thread in PROCS corresponds to each task thread, & the task. */ - struct proc *matched[num_threads + 1]; + /* Which thread in PROCS corresponds to each task thread. */ + struct proc **matched = XNEWVEC (struct proc *, num_threads); /* The last thread in INF->threads, so we can add to the end. */ struct proc *last = 0; /* The current thread we're considering. */ struct proc *thread = inf->threads; - memset (matched, 0, sizeof (matched)); + memset (matched, 0, sizeof (struct proc *) * num_threads); while (thread) { @@ -1090,6 +1090,7 @@ gnu_nat_target::inf_validate_procs (struct inf *inf) } } + xfree (matched); vm_deallocate (mach_task_self (), (vm_address_t) threads, (num_threads * sizeof (thread_t))); } -- 2.45.2