From: "H.J. Lu" <hjl.tools@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix Linux/i386 register set size
Date: Tue, 20 Apr 2010 21:45:00 -0000 [thread overview]
Message-ID: <t2y6dc9ffc81004201445iedc8c3b6x76b7b784eecfd858@mail.gmail.com> (raw)
In-Reply-To: <201004201942.o3KJgtMB025587@glazunov.sibelius.xs4all.nl>
On Tue, Apr 20, 2010 at 12:42 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> Should be 68. Confusion is probably caused by the fact that the note
> size is 144, and that the amd64 register set is also 144. The fact
> that the GDB gcore produces wrong core files in the 32x64 case doesn't
> help either.
>
> Committed.
>
>
> 2010-04-20 Mark Kettenis <kettenis@gnu.org>
>
> * i386-linux-tdep.c (i386_linux_regset_sections): Size of the
> general-purpose register set should be 68 instead of 144.
> (i386_linux_sse_regset_sections): Likewise.
> (i386_linux_avx_regset_sections): Likewise.
>
>
On Linux, ".reg" section is a special case. Its size is ignored.
See linux_nat_do_thread_registers for details. You can set
it to anything and it doesn't make a difference.
--
H.J.
next prev parent reply other threads:[~2010-04-20 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 19:43 Mark Kettenis
2010-04-20 21:45 ` H.J. Lu [this message]
2010-04-22 19:43 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=t2y6dc9ffc81004201445iedc8c3b6x76b7b784eecfd858@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox