Re: [RFA]: x86_64 target

[Mark Kettenis <kettenis@science.uva.nl>]

Hi Jiri,

You're not listed under Write After Approval in the MAINTAINERS file
yet.  Andrew, is Jiri's paperwork in order?  If it is then:

The i386-nat.c changes are approved.

There are some comments in x86-64-linux-nat.c that you took from
i386-linux-nat.c, but that don't really apply in your case:

 - The comment that starts with:

   /* The register sets used in Linux ELF core-dumps...

   Replacing it with

   /* The register sets used in Linux ELF core-dumps are identical to the
      register sets used by `ptrace'.  */

   should be enough.

 - The comment that talks about PTRACE_SETFPXREGS doesn't make sense
   for x86_64.  Just leave it out.

Is the stuff in x86-64-nat.c really necessary?

Please remove the extra whitespace at the end of nm-x86-64.h.

Please do not apply the patches to NEWS and configure.host and
configure.tgt until all the other stuff is checked in.

With those changes, the rest if this stuff also approved.  I'll
probably start working on multi-arching some of the i386 targets once
you've checked this in.  In that process I'll probably want to touch
i386-tdep.h and x86_64-tdep.c, so we should work out how to ccoperate
without hindering eachother too much on those bits.

Cheers,

Mark