From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Kettenis <kettenis@science.uva.nl>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/i387] Eliminate HOST_*_FORMAT from i387-tdep.c
Date: Sun, 01 Jul 2001 05:56:00 -0000
Message-id: <s3ipubkolli.fsf@soliton.wins.uva.nl>
References: <3B3CB299.5000100@cygnus.com>
X-SW-Source: 2001-07/msg00002.html

Andrew Cagney <ac131313@cygnus.com> writes:

> Hello,
> 
> Very similar to my ARM tweek, this patch replaces a use of 
> HOST_LONG_DOUBLE_FORMAT with more generic code.
> 
> There isn't a loss of precision since extract_floating() on i386 native 
> should still do a memcopy().

Hmm, the new code seems to assume that

   TARGET_LONG_DOUBLE_FORMAT == &floatformat_i387_ext

This isn't true for OSF/1, but that target doesn't use this code (and
probably doesn't compile anyway).  Nevertheless, I think you should
add a

   gdb_assert (TARGET_LONG_DOUBLE_FORMAT == &floatformat_i387_ext);

instead of, or in addition to the

   gdb_assert (FPU_REG_RAW_SIZE < len);

Consider it approved with that change.

Oh, and I believe the GNU coding standards demand two spaces after a
full stop, even at the end of a comment.

Mark