From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Kettenis <kettenis@science.uva.nl>
To: Kevin Buettner <kevinb@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Fix xasprintf() usage in solib-aix5.c
Date: Tue, 27 Mar 2001 01:46:00 -0000
Message-id: <s3in1a7wnmf.fsf@debye.wins.uva.nl>
References: <1010327062855.ZM2972@ocotillo.lan>
X-SW-Source: 2001-03/msg00489.html

Kevin Buettner <kevinb@cygnus.com> writes:

> I've just committed the change below.
> 
> 	* solib-aix5.c (build_so_lib_from_mapfile): Fix xasprintf() usage.
> 
> Index: solib-aix5.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/solib-aix5.c,v
> retrieving revision 1.7
> diff -u -p -r1.7 solib-aix5.c
> --- solib-aix5.c	2001/03/16 18:06:44	1.7
> +++ solib-aix5.c	2001/03/27 06:18:58
> @@ -193,13 +193,14 @@ build_so_list_from_mapfile (int pid, lon
>  
>    {
>      int mapbuf_allocation_size = 8192;
> -    char map_pathname[64];
> +    char *map_pathname;
>      int map_fd;
>  
>      /* Open the map file */
>  
> -    xasprintf (map_pathname, "/proc/%d/map", pid);
> +    xasprintf (&map_pathname, "/proc/%d/map", pid);
>      map_fd = open (map_pathname, O_RDONLY);
> +    free (map_pathname);

Shouldn't that be xfree()?

>      if (map_fd < 0)
>        return 0;
>