From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30173 invoked by alias); 10 Apr 2010 21:23:08 -0000 Received: (qmail 30114 invoked by uid 22791); 10 Apr 2010 21:23:07 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45 X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Apr 2010 21:23:01 +0000 Received: by vws15 with SMTP id 15so837488vws.0 for ; Sat, 10 Apr 2010 14:22:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.15.129 with HTTP; Sat, 10 Apr 2010 14:22:59 -0700 (PDT) In-Reply-To: <1270933267-14720-1-git-send-email-crquan@gmail.com> References: <1270933267-14720-1-git-send-email-crquan@gmail.com> Date: Sat, 10 Apr 2010 21:23:00 -0000 Received: by 10.220.108.83 with SMTP id e19mr928372vcp.165.1270934579585; Sat, 10 Apr 2010 14:22:59 -0700 (PDT) Message-ID: Subject: Re: [PATCH] disassemble support start,+length format From: Cheng Renquan To: gdb-patches@sourceware.org, Tom Tromey Cc: Hui Zhu , Joel Brobecker , Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00309.txt.bz2 On Sun, Apr 11, 2010 at 5:01 AM, Cheng wrote: > Index: gdb/cli/cli-cmds.c [...] > @@ -1119,8 +1120,16 @@ disassemble_command (char *arg, int from > =C2=A0 else > =C2=A0 =C2=A0 { > =C2=A0 =C2=A0 =C2=A0 /* Two arguments. =C2=A0*/ > + =C2=A0 =C2=A0 =C2=A0int incl_flag =3D 0; > =C2=A0 =C2=A0 =C2=A0 low =3D pc; > + =C2=A0 =C2=A0 =C2=A0if (arg[0] =3D=3D '+') > + =C2=A0 =C2=A0 =C2=A0{ > + =C2=A0 =C2=A0 =C2=A0 ++arg; > + =C2=A0 =C2=A0 =C2=A0 incl_flag =3D 1; > + =C2=A0 =C2=A0 =C2=A0} > =C2=A0 =C2=A0 =C2=A0 high =3D parse_and_eval_address (arg); > + =C2=A0 =C2=A0 =C2=A0if (incl_flag) > + =C2=A0 =C2=A0 =C2=A0 high +=3D low; This should satisfy GNU Coding Standards well, On Fri, Apr 9, 2010 at 6:27 PM, Eli Zaretskii wrote: >> OK, I really know little about texinfo writing; Thanks, > > That's fine, I'm here to help ;-) > > Thanks for working on this. I think there to add one disassemble example in the info file may be better, but haven't figured out how to preview such a texinfo file, the make process seems not touch it or use it to generate another file? suseuser@linux-orm5:~/src/gdb-trunk/src> info -f gdb/doc/gdb.texinfo info: Cannot find node `Top'. On Sat, Apr 10, 2010 at 2:14 AM, Tom Tromey wrote: >>> From: CHENG Renquan >>> add new support for disassemble by "start,+length" format; > > Do you have a copyright assignment in place? > If not, let me know and I can get you started. Not yet, you may mean a signed agreement to GNU FSF? I was formerly asked to sign one when posting a patch to GNU wget last year, but still don't get further messages there, I wonder if softcopy of signment is accepted? please help get me restarted since this gdb patch, thanks, --=20 Cheng Renquan (=E7=A8=8B=E4=BB=BB=E5=85=A8), from Singapore