From: Doug Evans <dje@google.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] gdbserver: print inferior argv --debug
Date: Sat, 24 Apr 2010 00:59:00 -0000 [thread overview]
Message-ID: <s2ie394668d1004231759vf0e3376bh8313890f333d2e95@mail.gmail.com> (raw)
In-Reply-To: <-6536644988877721859@unknownmsgid>
Thanks. I checked this in with the added double-quotes.
On Tue, Apr 20, 2010 at 12:53 AM, Pierre Muller
<pierre.muller@ics-cnrs.unistra.fr> wrote:
> Not an objection, rather a suggestion:
> what about wrapping these args into double quotes to
> see embedded spaces like this:
>> + fprintf (stderr, "new_argv[%d] = \"%s\"\n", i, new_argv[i]);
>
> Pierre Muller
>
>> -----Message d'origine-----
>> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
>> owner@sourceware.org] De la part de Doug Evans
>> Envoyé : Tuesday, April 20, 2010 9:21 AM
>> À : gdb-patches@sourceware.org
>> Objet : [patch] gdbserver: print inferior argv --debug
>>
>> Hi.
>>
>> I found this helpful debugging gdbserver --wrapper.
>>
>> I will check it in in a few days if there are no objections.
>>
>> 2010-04-20 Doug Evans <dje@google.com>
>>
>> * server.c (start_inferior): Print inferior argv if --debug.
>>
>> Index: server.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
>> retrieving revision 1.116
>> diff -u -p -r1.116 server.c
>> --- server.c 16 Apr 2010 07:49:36 -0000 1.116
>> +++ server.c 20 Apr 2010 07:14:54 -0000
>> @@ -241,6 +241,14 @@ start_inferior (char **argv)
>> new_argv[count] = NULL;
>> }
>>
>> + if (debug_threads)
>> + {
>> + int i;
>> + for (i = 0; new_argv[i]; ++i)
>> + fprintf (stderr, "new_argv[%d] = %s\n", i, new_argv[i]);
>> + fflush (stderr);
>> + }
>> +
>> #ifdef SIGTTOU
>> signal (SIGTTOU, SIG_DFL);
>> signal (SIGTTIN, SIG_DFL);
>
>
prev parent reply other threads:[~2010-04-24 0:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 7:21 Doug Evans
2010-04-20 7:53 ` Pierre Muller
[not found] ` <-6536644988877721859@unknownmsgid>
2010-04-20 7:55 ` Doug Evans
2010-04-24 0:59 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s2ie394668d1004231759vf0e3376bh8313890f333d2e95@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox