From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29377 invoked by alias); 27 Sep 2002 19:12:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29366 invoked from network); 27 Sep 2002 19:12:46 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by sources.redhat.com with SMTP; 27 Sep 2002 19:12:46 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id g8RJCjB14264; Fri, 27 Sep 2002 12:12:45 -0700 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: gdb-patches@sources.redhat.com Subject: [rfa] missing #include "gdb_string.h" From: David Carlton Date: Fri, 27 Sep 2002 12:12:00 -0000 Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-09/txt/msg00673.txt.bz2 I did an all targets build, and it's turned up some missing #include "gdb_string.h" locations. The patch is below; it's obvious, but I'm doing an RFA because I'm not actually running on the target machines in question and because I'm paranoid. For what it's worth, the targets powerpc-eabi and v850-elf fail when build with -Werror for other reasons; I haven't looked into them yet, and I have no reason to believe that they can't be fixed in a similarly trivial manner. David Carlton carlton@math.stanford.edu 2002-09-26 David Carlton * Makefile.in (cris-tdep.o): Depend on gdb_string_h. (mcore-tdep.o): Ditto. (ns32k-tdep.o): Ditto. (ns32knbsd-tdep.o): Ditto. (sh3-rom.o): Ditto. (vax-tdep.o): Ditto. * cris-tdep.c: #include "gdb_string.h" * mcore-tdep.c: Ditto. * ns32k-tdep.c: Ditto. * ns32knbsd-tdep.c: Ditto. * sh3-rom.c: Ditto. * vax-tdep.c: Ditto. Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.264 diff -u -p -r1.264 Makefile.in --- Makefile.in 26 Sep 2002 17:46:04 -0000 1.264 +++ Makefile.in 27 Sep 2002 19:04:51 -0000 @@ -1595,7 +1595,7 @@ cpu32bug-rom.o: cpu32bug-rom.c $(defs_h) cris-tdep.o: cris-tdep.c $(defs_h) $(frame_h) $(symtab_h) $(inferior_h) \ $(gdbtypes_h) $(gdbcore_h) $(gdbcmd_h) $(target_h) $(value_h) \ $(opcode_cris_h) $(arch_utils_h) $(regcache_h) $(symfile_h) \ - $(solib_h) $(solib_svr4_h) + $(solib_h) $(solib_svr4_h) $(gdb_string_h) # OBSOLETE cxux-nat.o: cxux-nat.c d10v-tdep.o: d10v-tdep.c $(defs_h) $(frame_h) $(symtab_h) $(gdbtypes_h) \ $(gdbcmd_h) $(gdbcore_h) $(gdb_string_h) $(value_h) $(inferior_h) \ @@ -1878,7 +1878,7 @@ mcore-rom.o: mcore-rom.c $(defs_h) $(gdb $(gdb_string_h) $(regcache_h) $(serial_h) mcore-tdep.o: mcore-tdep.c $(defs_h) $(frame_h) $(symtab_h) $(value_h) \ $(gdbcmd_h) $(regcache_h) $(symfile_h) $(gdbcore_h) $(inferior_h) \ - $(arch_utils_h) + $(arch_utils_h) $(gdb_string_h) mdebugread.o: mdebugread.c $(defs_h) $(symtab_h) $(gdbtypes_h) $(gdbcore_h) \ $(symfile_h) $(objfiles_h) $(gdb_obstack_h) $(buildsym_h) \ $(stabsread_h) $(complaints_h) $(demangle_h) $(gdb_assert_h) \ @@ -1931,10 +1931,10 @@ nlmread.o: nlmread.c $(defs_h) $(bfd_h) $(objfiles_h) $(buildsym_h) $(stabsread_h) ns32k-tdep.o: ns32k-tdep.c $(defs_h) $(frame_h) $(gdbtypes_h) $(gdbcore_h) \ $(inferior_h) $(regcache_h) $(target_h) $(arch_utils_h) \ - $(ns32k_tdep_h) + $(ns32k_tdep_h) $(gdb_string_h) ns32knbsd-nat.o: ns32knbsd-nat.c $(defs_h) $(inferior_h) $(target_h) \ $(gdbcore_h) $(regcache_h) -ns32knbsd-tdep.o: ns32knbsd-tdep.c $(defs_h) $(ns32k_tdep_h) +ns32knbsd-tdep.o: ns32knbsd-tdep.c $(defs_h) $(ns32k_tdep_h) $(gdb_string_h) objfiles.o: objfiles.c $(defs_h) $(bfd_h) $(symtab_h) $(symfile_h) \ $(objfiles_h) $(gdb_stabs_h) $(target_h) $(bcache_h) $(gdb_stat_h) \ $(gdb_obstack_h) $(gdb_string_h) $(breakpoint_h) $(mmalloc_h) @@ -2108,7 +2108,8 @@ sh-tdep.o: sh-tdep.c $(defs_h) $(frame_h $(regcache_h) $(doublest_h) $(sh_tdep_h) $(elf_bfd_h) \ $(solib_svr4_h) $(elf_sh_h) $(gdb_sim_sh_h) sh3-rom.o: sh3-rom.c $(defs_h) $(gdbcore_h) $(target_h) $(monitor_h) \ - $(serial_h) $(srec_h) $(arch_utils_h) $(regcache_h) $(sh_tdep_h) + $(serial_h) $(srec_h) $(arch_utils_h) $(regcache_h) $(gdb_string_h) \ + $(sh_tdep_h) shnbsd-nat.o: shnbsd-nat.c $(defs_h) $(inferior_h) $(shnbsd_tdep_h) shnbsd-tdep.o: shnbsd-tdep.c $(defs_h) $(gdbcore_h) $(regcache_h) $(value_h) \ $(solib_svr4_h) $(nbsd_tdep_h) $(sh_tdep_h) $(shnbsd_tdep_h) @@ -2256,7 +2257,7 @@ varobj.o: varobj.c $(defs_h) $(value_h) $(language_h) $(wrapper_h) $(gdbcmd_h) $(gdb_string_h) $(varobj_h) vax-tdep.o: vax-tdep.c $(defs_h) $(symtab_h) $(opcode_vax_h) $(gdbcore_h) \ $(inferior_h) $(regcache_h) $(frame_h) $(value_h) $(arch_utils_h) \ - $(vax_tdep_h) + $(gdb_string_h) $(vax_tdep_h) w89k-rom.o: w89k-rom.c $(defs_h) $(gdbcore_h) $(target_h) $(monitor_h) \ $(serial_h) $(xmodem_h) $(regcache_h) win32-nat.o: win32-nat.c $(defs_h) $(tm_h) $(frame_h) $(inferior_h) \ Index: cris-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/cris-tdep.c,v retrieving revision 1.22 diff -u -p -r1.22 cris-tdep.c --- cris-tdep.c 17 Sep 2002 20:42:01 -0000 1.22 +++ cris-tdep.c 27 Sep 2002 19:04:52 -0000 @@ -37,6 +37,7 @@ Foundation, Inc., 59 Temple Place - Suit #include "solib.h" /* Support for shared libraries. */ #include "solib-svr4.h" /* For struct link_map_offsets. */ +#include "gdb_string.h" enum cris_num_regs Index: mcore-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mcore-tdep.c,v retrieving revision 1.20 diff -u -p -r1.20 mcore-tdep.c --- mcore-tdep.c 17 Sep 2002 20:42:01 -0000 1.20 +++ mcore-tdep.c 27 Sep 2002 19:04:52 -0000 @@ -27,6 +27,7 @@ #include "gdbcore.h" #include "inferior.h" #include "arch-utils.h" +#include "gdb_string.h" /* Functions declared and used only in this file */ Index: ns32k-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/ns32k-tdep.c,v retrieving revision 1.17 diff -u -p -r1.17 ns32k-tdep.c --- ns32k-tdep.c 24 Aug 2002 00:21:35 -0000 1.17 +++ ns32k-tdep.c 27 Sep 2002 19:04:52 -0000 @@ -30,6 +30,7 @@ #include "arch-utils.h" #include "ns32k-tdep.h" +#include "gdb_string.h" static int sign_extend (int value, int bits); static CORE_ADDR ns32k_get_enter_addr (CORE_ADDR); Index: ns32knbsd-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/ns32knbsd-tdep.c,v retrieving revision 1.1 diff -u -p -r1.1 ns32knbsd-tdep.c --- ns32knbsd-tdep.c 27 May 2002 01:05:16 -0000 1.1 +++ ns32knbsd-tdep.c 27 Sep 2002 19:04:52 -0000 @@ -22,6 +22,7 @@ #include "defs.h" #include "ns32k-tdep.h" +#include "gdb_string.h" static int ns32knbsd_aout_in_solib_call_trampoline (CORE_ADDR pc, char *name) Index: sh3-rom.c =================================================================== RCS file: /cvs/src/src/gdb/sh3-rom.c,v retrieving revision 1.12 diff -u -p -r1.12 sh3-rom.c --- sh3-rom.c 17 May 2002 06:55:48 -0000 1.12 +++ sh3-rom.c 27 Sep 2002 19:04:53 -0000 @@ -27,6 +27,7 @@ #include "srec.h" #include "arch-utils.h" #include "regcache.h" +#include "gdb_string.h" #include "sh-tdep.h" Index: vax-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/vax-tdep.c,v retrieving revision 1.18 diff -u -p -r1.18 vax-tdep.c --- vax-tdep.c 24 Aug 2002 00:21:35 -0000 1.18 +++ vax-tdep.c 27 Sep 2002 19:04:53 -0000 @@ -28,6 +28,7 @@ #include "frame.h" #include "value.h" #include "arch-utils.h" +#include "gdb_string.h" #include "vax-tdep.h"