From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28399 invoked by alias); 23 Oct 2002 22:43:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28389 invoked from network); 23 Oct 2002 22:43:29 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by sources.redhat.com with SMTP; 23 Oct 2002 22:43:29 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id g9NMhMd19219; Wed, 23 Oct 2002 15:43:22 -0700 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Elena Zannoni Cc: gdb-patches@sources.redhat.com, Jim Blandy Subject: Re: [patch] useless code in symtab.c References: <15799.9088.601916.908293@localhost.redhat.com> From: David Carlton Date: Wed, 23 Oct 2002 15:43:00 -0000 In-Reply-To: <15799.9088.601916.908293@localhost.redhat.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-10/txt/msg00487.txt.bz2 On Wed, 23 Oct 2002 18:32:32 -0400, Elena Zannoni said: > Can you also knock out the one at: > linespec.c:38:extern char *find_template_name_end (char *); That one gets used by decode_line_1. (One of these days, I'll try to understand what that function is doing, but I'm not feeling quite that masochistic yet.) Though I don't see any compelling reason not to just #include "parser-defs.h" there instead of declaring that one function specially; should I go ahead and do that? (Looking through ChangeLogs, I see that code in linespec.c used to be in symtab.c; that explains why the prototype was in symtab.c.) David Carlton carlton@math.stanford.edu