From: David Carlton <carlton@math.stanford.edu>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] revert my previous search_symbols change, add comment
Date: Thu, 20 Feb 2003 21:03:00 -0000 [thread overview]
Message-ID: <ro1wuju4qcf.fsf@jackfruit.Stanford.EDU> (raw)
In-Reply-To: <15957.16088.234106.47580@localhost.redhat.com>
On Thu, 20 Feb 2003 15:47:20 -0500, Elena Zannoni <ezannoni@redhat.com> said:
> David Carlton writes:
>> In my patch from 2002-12-23, I changed some code in search_symbols
>> from a call to lookup_symbol to a call to lookup_symbol_aux_minsyms.
>> At that time, I didn't understand exactly what
>> lookup_symbol_aux_minsyms did; now that I understand that function
>> better, I don't think that change was a good idea.
>>
>> So this patch reverts that change. At Andrew's suggestion, I've added
>> a comment as well, saying what I'd really like to replace the call to
>> lookup_symbol with.
> OK
Thanks; I'll commit it in a sec.
>> In my next patch, I'll change lookup_symbol_aux_minsyms to actually do
>> something correct (now that Daniel has been kind enough to demangle
>> partial symbols for me), but I wanted to get this part of the change
>> out of the way first.
>>
> Question, where does the other patch I just replied to stand wrt to this?
> Should we forget about the old patch?
Crossing e-mails; by now, you've gotten the e-mail where I explain
that, or will in a sec.
David Carlton
carlton@math.stanford.edu
prev parent reply other threads:[~2003-02-20 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-05 0:24 David Carlton
2003-02-20 20:43 ` Elena Zannoni
2003-02-20 21:03 ` David Carlton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ro1wuju4qcf.fsf@jackfruit.Stanford.EDU \
--to=carlton@math.stanford.edu \
--cc=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox