Re: [RFA/TESTSUITE] annota1.exp fixes

[David Carlton <carlton@math.stanford.edu>]

On Tue, 8 Apr 2003 18:53:21 -0400, Elena Zannoni <ezannoni@redhat.com> said:

> The test was too eager in matching the whole path to the source file.
> What's really happening is that it wouldn't match a '+' in the
> directory name. (In RedHat gdb the source directory is named the same
> as the sourceware snapshots i.e. gdb+dejagnu, which now I know not to
> do again).

For what it's worth, I had another problem with those regexps a while
ago: I'm getting output that included subdir but not srcdir.
(Presumably I'm the only one seeing this because I actually build in
the source directory.)  I submitted a patch to allow that; Fernando's
response was that he didn't know if that was allowable output, so we
should check with annotation users to make sure.  And nobody ever did
that.

Your regexps accept the output that I'm seeing.  So if we're really
nervous about not wanting to accept my output, then probably your
patches aren't a great idea, and we should instead modify them to
create new variables srcdir-regexp and subdir-regexp (or whatever)
that are regexp-protected, and use them.  On the other hand, I'm
inclined to go with your patches: the regexps already accept it if
both srcdir and subdir are missing, so could it really be any worse if
just srcdir is missing?

By the way, my original message was in a thread titled
"[rfa/testsuite] make annota1 regexps more generous"; see also a
threat titled "[RFA] annota1.exp: Don't require complete pathname in
info break test".

David Carlton
carlton@math.stanford.edu