From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25074 invoked by alias); 18 Dec 2002 19:18:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25065 invoked from network); 18 Dec 2002 19:18:39 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by 209.249.29.67 with SMTP; 18 Dec 2002 19:18:39 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id gBIJIQQ10955; Wed, 18 Dec 2002 11:18:26 -0800 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Michael Elizabeth Chastain Cc: drow@mvista.com, gdb-patches@sources.redhat.com Subject: Re: [patch] delete namespace __gnu_test from C++ testsuite References: <200212181900.gBIJ0cQ14489@duracef.shout.net> From: David Carlton Date: Wed, 18 Dec 2002 11:46:00 -0000 In-Reply-To: <200212181900.gBIJ0cQ14489@duracef.shout.net> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-12/txt/msg00541.txt.bz2 On Wed, 18 Dec 2002 13:00:38 -0600, Michael Elizabeth Chastain said: > I would change this code: > # simple object, enum > gdb_test "print test1.value" "\\$\[0-9\]* = egyptian" "simple object, enum" > To: > send_gdb "test1.value\n" > gdb_expect { > -re "\\$\[0-9\]+ = __gnu_test::egyptian\r\n$gdb_prompt $" { > pass "simple object, enum > } > -re "\\$\[0-9\]+ = egyptain\r\n$gdb_prompt $" { > fail "simple object, enum (gdb/895)" > } > -re ".*$gdb_prompt $" { > fail "simple object, enum" > } > timeout { > fail "simple object, enum (timeout)" > } I'll add something like this to the testsuite soon. (Hopefully over the next few days; definitely before Winter quarter starts.) > In the "= egyptian" case, I would call kfail or setup_kfail as soon > as we start using KFAIL's. KFAIL is moving way up my priority list. Yup. I think I'll KFAIL something today; I'm just looking for the right bug to start with. One possibility is gdb.c++/annota2.exp's annotate-quit, corresponding to PR 544. > If the "= egyptian" case is due to bad output from gcc, then I would > add a big comment and then call setup_xfail (or call xfail outright). > I would also want to have a gcc bug # in hand and refer to it in > the test script source. We can't get it right without GCC's help. But currently we wouldn't get it right even if GCC were helping, so I think that KFAIL is appropriate for now. Getting this completely correct is going to be a bit of a delicate issue, actually: eventually, we'll need to be able to conditially XFAIL tests based on the compiler version number, if we really want to be scrupulously correct in this regard. David Carlton carlton@math.stanford.edu