From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22695 invoked by alias); 20 Dec 2002 20:18:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22677 invoked from network); 20 Dec 2002 20:18:51 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by 209.249.29.67 with SMTP; 20 Dec 2002 20:18:51 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id gBKKHlL19586; Fri, 20 Dec 2002 12:17:47 -0800 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Elena Zannoni Cc: mec@shout.net, gdb-patches@sources.redhat.com, Jim Blandy Subject: Re: [rfa] delete 'force_return' from lookup_symbol_aux_minsyms References: <15861.1750.232869.77936@localhost.redhat.com> <15873.63708.366837.407436@localhost.redhat.com> <15874.18989.470549.778392@localhost.redhat.com> <15874.24175.313746.528320@localhost.redhat.com> From: David Carlton Date: Fri, 20 Dec 2002 13:02:00 -0000 In-Reply-To: <15874.24175.313746.528320@localhost.redhat.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-12/txt/msg00599.txt.bz2 On Thu, 19 Dec 2002 19:03:59 -0500, Elena Zannoni said: > David Carlton writes: >> On Thu, 19 Dec 2002 17:37:33 -0500, Elena Zannoni said: >>> David Carlton writes: >>>> Suggestion #2: Maybe we should put this particular patch on hold and >>>> come to some sort of consensus as to how to deal with >>>> mangled/demangled names. I'll post an RFC for that later today. >>> Ok, whatever seems easier for you. Although I think we can try to >>> fix the parameter problem, at least, and see what breaks. >> I started to write an RFC, but actually I think now isn't the best >> time for that: it'll affect GDB fairly broadly, and enough people >> are away on holidays that I don't want to propose that right now. >> So, in early January, I'll see if I can get some sort of consensus >> towards the right way to approach this. > Alternatively you can post something and wait a bit. Maybe MichaelC > will put it through his test harness. I think that this issue is comprehensive enough both to deserve an RFC and to require a series of patches to resolve. (Maybe even another branch...) >> Here's a revised version of the patch: it's exactly the same as the >> previous one, except that it changes the call to lookup_symbol in >> search_symbols to call lookup_symbol_aux_minsyms instead. Tested on >> i686-pc-linux-gnu/GCC 3.1/DWARF 2 (Michael Chastain has been nagging >> me to give such info, but don't worry, I always test my patches :-) ); >> no new regressions. > Since all this code was written when stabs was king, maybe we'll find > differences with stabs testing. Also, given that as you say, people > are on vacation, the entropy of gdb should be a bit lower these days, > and if something breaks, it's probably because of this change, so it > should be more easily trackable. :-) > OK. Great. Then I'll commit it now, and I'll hold off on my next patch in this series (which this was setting up ground work for) until some time in January, so that Michael's tests have had a chance to see it and other people will be back from vacation and had a chance to run into it. That way, it will be easy to back out if necessary. And I'll start working on a function "lookup_symbol_minsym" which tries to find the symbol associated to a minsym: that would probably be the best way to handle that call to lookup_symbol from within search_symbols that we're replacing by a call to lookup_symbol_aux_minsyms. I think it will be useful elsewhere, as well: when I skimmed all the callers to lookup_symbol, I remember finding some other places that wanted to match a symbol to a specific mangled name, and they probably got that mangled name from a minsym. David Carlton carlton@math.stanford.edu