Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Carlton <carlton@math.stanford.edu>
To: Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sources.redhat.com, Jim Blandy <jimb@red-bean.com>,
	Elena Zannoni <ezannoni@redhat.com>
Subject: Re: [rfc] split up symtab.h
Date: Tue, 08 Oct 2002 15:22:00 -0000	[thread overview]
Message-ID: <ro1u1jwk1up.fsf@jackfruit.Stanford.EDU> (raw)
In-Reply-To: <3DA357B6.B37C5BC7@redhat.com>

On Tue, 08 Oct 2002 15:09:58 -0700, Michael Snyder <msnyder@redhat.com> said:
> David Carlton wrote:

>> struct general_symbol_info (1)

> Careful.  Struct general_symbol_info is mentioned in LOTS of
> places...  indirectly, thru uses of the macros SYMBOL_NAME,
> SYMBOL_TYPE, etc.

Right, that particular count is totally misleading.  Aside from the
macros that you mentioned, the definitions of struct
{minimal_,partial_,}symbol all need to have the definition of struct
general_symbol_info available as well.  So there would be nontrivial
dependencies among the header files that I was proposing.  (I _think_
the only nontrivial dependencies arise from 'struct
general_symbol_info' and from enums, but I could be wrong.)

Personally, I'd be quite tempted to have the header files for
minimal_symbol, symbol, and partial_symbol all include the header file
for general_symbol_info; I realize that GDB prefers to avoid that, but
here is a situation where the usual substitute, namely opaque
declarations of structures, doesn't work.

Also, the correct location of namespace_enum isn't clear to me; too
bad C doesn't support opaque declarations of enums.  And the exact
placements of partial_ stuff isn't clear to me: it seems plausible to
me that 'struct partial_symbol' should either be in the same include
file as 'struct symbol' or in the same file as 'struct
partial_symtab', but which?

David Carlton
carlton@math.stanford.edu


  reply	other threads:[~2002-10-08 22:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-08 13:14 David Carlton
2002-10-08 13:54 ` Kevin Buettner
2002-10-08 15:05   ` David Carlton
2002-10-08 15:11 ` Michael Snyder
2002-10-08 15:22   ` David Carlton [this message]
2002-10-18 14:12 ` Elena Zannoni
2002-10-18 14:52   ` David Carlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ro1u1jwk1up.fsf@jackfruit.Stanford.EDU \
    --to=carlton@math.stanford.edu \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@red-bean.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox