From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28342 invoked by alias); 19 Sep 2002 16:29:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28335 invoked from network); 19 Sep 2002 16:29:14 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by sources.redhat.com with SMTP; 19 Sep 2002 16:29:14 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id g8JGSN623787; Thu, 19 Sep 2002 09:28:23 -0700 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Hilfinger@otisco.mckusick.com Cc: gdb-patches@sources.redhat.com, aidan@velvet.net, jimb@redhat.com, ezannoni@redhat.com Subject: Re: [RFA] delete BLOCK_SHOULD_SORT References: <200209190804.BAA27599@otisco.McKusick.COM> From: David Carlton Date: Thu, 19 Sep 2002 09:29:00 -0000 In-Reply-To: <200209190804.BAA27599@otisco.McKusick.COM> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-09/txt/msg00491.txt.bz2 On Thu, 19 Sep 2002 01:04:10 -0700, "Paul N. Hilfinger" said: > OK; let me explain what Ada is up to in the various places it does > symbol lookup, and you can decide if we (ahem) need a conversation > on this (vis-a-vis this thread or the other "dictionary" threads), > or if our needs introduce no new requirements. ... > The second pattern, however, can benefit for sorted blocks in an > obvious way--- hence the ada-lang.c code you mentioned in an earlier > message---but doesn't need them. That is, we take advantage of > BLOCK_SHOULD_SORT when possible. I don't have measurements of the > impact of not having it. I see; thanks for the explanation. Then I agree with Daniel: it should probably be converted to search_symbols, and removing BLOCK_SHOULD_SORT won't hurt you: the performance gains that you had been getting were already lost in the earlier conversion from sorted lists to hashtables, unless the debugging info happens to be in ECOFF format. So the only question is whether or not I slipped up when converting those loops to ALL_BLOCK_SYMBOLS. David Carlton carlton@math.stanford.edu