From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20149 invoked by alias); 27 Sep 2002 19:31:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20110 invoked from network); 27 Sep 2002 19:31:47 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by sources.redhat.com with SMTP; 27 Sep 2002 19:31:47 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id g8RJVdJ14326; Fri, 27 Sep 2002 12:31:39 -0700 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa] missing #include "gdb_string.h" References: <3D94B119.9000306@redhat.com> From: David Carlton Date: Fri, 27 Sep 2002 12:31:00 -0000 In-Reply-To: <3D94B119.9000306@redhat.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-09/txt/msg00677.txt.bz2 On Fri, 27 Sep 2002 15:27:21 -0400, Andrew Cagney said: >> I did an all targets build, and it's turned up some missing >> #include "gdb_string.h" locations. The patch is below; it's >> obvious, but I'm doing an RFA because I'm not actually running on >> the target machines in question and because I'm paranoid. > It's ok. Great, I'll commit them in a sec. >> For what it's worth, the targets powerpc-eabi and v850-elf fail when >> build with -Werror for other reasons; I haven't looked into them yet, >> and I have no reason to believe that they can't be fixed in a >> similarly trivial manner. > Which compiler/host? GCC 3.1, Red Hat Linux 7.3. Here are the relevant error messages: >>>>>>>>>>>>> powerpc-eabi () gcc -c -g -O2 -I. -I/extra/gdb/nightly/src/gdb -I/extra/gdb/nightly/src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I/extra/gdb/nightly/src/gdb/../include/opcode -I/extra/gdb/nightly/src/gdb/../readline/.. -I../bfd -I/extra/gdb/nightly/src/gdb/../bfd -I/extra/gdb/nightly/src/gdb/../include -I../intl -I/extra/gdb/nightly/src/gdb/../intl -DMI_OUT=1 -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized -Werror /extra/gdb/nightly/src/gdb/remote-sds.c cc1: warnings being treated as errors /extra/gdb/nightly/src/gdb/remote-sds.c: In function `getmessage': /extra/gdb/nightly/src/gdb/remote-sds.c:981: warning: deprecated use of label at end of compound statement make[1]: *** [remote-sds.o] Error 1 make[1]: Leaving directory `/extra/gdb/nightly/builds/gdb-allcross/powerpc-eabi/gdb' make: *** [all-gdb] Error 2 >>>>>>>>>>>>> v850-elf () gcc -c -g -O2 -I. -I/extra/gdb/nightly/src/gdb -I/extra/gdb/nightly/src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I/extra/gdb/nightly/src/gdb/../include/opcode -I/extra/gdb/nightly/src/gdb/../readline/.. -I../bfd -I/extra/gdb/nightly/src/gdb/../bfd -I/extra/gdb/nightly/src/gdb/../include -I../intl -I/extra/gdb/nightly/src/gdb/../intl -DMI_OUT=1 -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized -Werror /extra/gdb/nightly/src/gdb/v850-tdep.c /extra/gdb/nightly/src/gdb/v850-tdep.c:177: `bfd_mach_v850ea' undeclared here (not in a function) /extra/gdb/nightly/src/gdb/v850-tdep.c:177: initializer element is not constant /extra/gdb/nightly/src/gdb/v850-tdep.c:177: (near initialization for `v850_processor_type_table[2].mach') /extra/gdb/nightly/src/gdb/v850-tdep.c:177: initializer element is not constant /extra/gdb/nightly/src/gdb/v850-tdep.c:177: (near initialization for `v850_processor_type_table[2]') /extra/gdb/nightly/src/gdb/v850-tdep.c:181: initializer element is not constant /extra/gdb/nightly/src/gdb/v850-tdep.c:181: (near initialization for `v850_processor_type_table[3]') make[1]: *** [v850-tdep.o] Error 1 make[1]: Leaving directory `/extra/gdb/nightly/builds/gdb-allcross/v850-elf/gdb' make: *** [all-gdb] Error 2 David Carlton carlton@math.stanford.edu