From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9027 invoked by alias); 27 Jan 2003 19:10:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9017 invoked from network); 27 Jan 2003 19:10:33 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by 172.16.49.205 with SMTP; 27 Jan 2003 19:10:33 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id h0RJAV501613; Mon, 27 Jan 2003 11:10:31 -0800 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: RFC: Demangle partial symbols and save memory too References: <20030126222808.GA18132@nevyn.them.org> <20030127190109.GA11294@nevyn.them.org> From: David Carlton Date: Mon, 27 Jan 2003 19:10:00 -0000 In-Reply-To: <20030127190109.GA11294@nevyn.them.org> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-01/txt/msg00734.txt.bz2 On Mon, 27 Jan 2003 14:01:09 -0500, Daniel Jacobowitz said: > On Mon, Jan 27, 2003 at 10:53:35AM -0800, David Carlton wrote: >> Personally, I'd prefer that name be const char *. > Thanks for reminding me; I'll fix the first const char *. You'll > notice I fixed the ugly places I was modifying it already, from our > last discussion. Yup! >> Well, I like this better than the last time I saw it, but I'll still >> give you a hard time. :-) You're assuming that name[len] is readable, >> for the sake of an optimization that doesn't seem to me to have much >> of a benefit (it could even be a pessimization if a high enough >> proportion of names have name[len] nonzero, though that seems unlikely >> to me). On the other hand, it does seem silly to copy the name if you >> don't have to; a matter of taste, I suppose. > It's simple: > - stabs, name[len] will be readable but generally non-zero. > - everything else, name[len] will be zero. > Hmm, think it would be better to push the alloca out into the stabs > callers? Maybe that would work. Oh, I wouldn't go to that length unless you're particularly motivated. Also, you'd have to change add_psymbol_to_list if you went that way. David Carlton carlton@math.stanford.edu