From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25373 invoked by alias); 19 Feb 2003 23:27:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25366 invoked from network); 19 Feb 2003 23:27:44 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by 172.16.49.205 with SMTP; 19 Feb 2003 23:27:44 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id h1JNRQU10855; Wed, 19 Feb 2003 15:27:26 -0800 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Andrew Cagney Cc: gdb-patches@sources.redhat.com, Jim Blandy , Elena Zannoni Subject: Re: [rfa] block.{c,h} References: <3E541124.6010203@redhat.com> From: David Carlton Date: Wed, 19 Feb 2003 23:27:00 -0000 In-Reply-To: <3E541124.6010203@redhat.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-02/txt/msg00449.txt.bz2 On Wed, 19 Feb 2003 18:20:04 -0500, Andrew Cagney said: > (symtabs problem but,) some anal things. > The actual restructuring was previously ok'ed. >> +/* Code dealing with blocks for GDB. > ..., the GNU debugger. Sure. >> + Copyright 2003 Free Software Foundation, Inc. >> + >> + This file is part of GDB. >> + >> + This program is free software; you can redistribute it and/or modify >> + it under the terms of the GNU General Public License as published by >> + the Free Software Foundation; either version 2 of the License, or >> + (at your option) any later version. >> + >> + This program is distributed in the hope that it will be useful, >> + but WITHOUT ANY WARRANTY; without even the implied warranty of >> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + GNU General Public License for more details. >> + >> + You should have received a copy of the GNU General Public License >> + along with this program; if not, write to the Free Software >> + Foundation, Inc., 59 Temple Place - Suite 330, >> + Boston, MA 02111-1307, USA. */ >> + > #ifndef BLOCK_H > #define BLOCK_H Ack! I'm a dolt. > .... > * Makefile.in (SFILES): block.c > ``Add "block.c".'' > Complete sentence, leading capital, end in fullstop. Same for > others. Sure. >> * blockframe.c: Move blockvector_for_pc_sect, blockvector_for_pc, >> block_for_pc_sect, block_for_pc to block.c. > Use with the correct changelog format, function names and the like in > paren vis: > (blockvector_for_pc_sect): Moved to "block.c". Okay. >> * frame.h: Move block_for_pc and block_for_pc_sect declarations to >> block.h. Add opaque declaration for struct block. >> * symtab.h: Move block-related stuff to block.h. Add opaque >> declarations for struct block, struct blockvector. > List them. Okay. > Squishing the changelog a little wouldn't hurt :-) All right, all right, how's this? Same as before, with the two changes to block.h mentioned at the top of the file, and this entry for the toplevel ChangeLog: 2003-02-19 David Carlton * Makefile.in (SFILES): Add block.c. (block_h): New. (COMMON_OBS): Add block.o. (block.o): New. (x86-64-tdep.o): Add $(block_h). (values.o, valops.o, tracepoint.o, symtab.o, symmisc.o, symfile.o, stack.o, printcmd.o, p-exp.tab.o, parse.o, objfiles.o, objc-exp.tab.o, objc-lang.o, nlmread.o, mips-tdep.o, mdebugread.o, m2-exp.tab.o, linespec.o, jv-lang.o, jv-exp.tab.o, infcmd.o, f-valprint.o, findvar.o, f-exp.tab.o, expprint.o, coffread.o, c-exp.tab.o, buildsym.o, breakpoint.o, blockframe.o, ax-gdb.o, alpha-tdep.o, ada-lang.o, ada-exp.tab.o, mi-cmd-stack.o): Ditto. * value.h: Add opaque declaration for struct block. * parser-defs.h, objc-lang.h, buildsym.h, breakpoint.h, ada-lang.h: Ditto. * x86-64-tdep.c: #include "block.h" * values.c, valops.c, tracepoint.c, symtab.c, symmisc.c, symfile.c, stack.c, printcmd.c, p-exp.y, parse.c, objfiles.c, objc-exp.y, objc-lang.c, nlmread.c, mips-tdep.c, mdebugread.c, m2-exp.y, linespec.c, jv-lang.c, jv-exp.y, infcmd.c, f-valprint.c, findvar.c, f-exp.y, expprint.c, coffread.c, c-exp.y, buildsym.c, breakpoint.c, blockframe.c, ax-gdb.c, alpha-tdep.c, ada-lang.c, ada-exp.y: Ditto. * blockframe.c (blockvector_for_pc_sect): Move to "block.c". (blockvector_for_pc, block_for_pc_sect, block_for_pc): Ditto. * symtab.c (block_function): Ditto. (contained_in): Ditto. * frame.h: Move block_for_pc and block_for_pc_sect declarations to block.h. Add opaque declaration for struct block. * symtab.h: Move block_function and contained_in declarations to block.h. Add opaque declarations for struct block, struct blockvector. (struct block): Move to block.h. (struct blockvector): Ditto. (BLOCK_START, BLOCK_END, BLOCK_FUNCTION, BLOCK_SUPERBLOCK, BLOCK_GCC_COMPILED, BLOCK_HASHTABLE, BLOCK_NSYMS, BLOCK_SYM, BLOCK_BUCKETS, BLOCK_BUCKET, BLOCK_HASHTABLE_SIZE, ALL_BLOCK_SYMBOLS, BLOCK_SHOULD_SORT, BLOCKVECTOR_NBLOCKS, BLOCKVECTOR_BLOCK, GLOBAL_BLOCK, STATIC_BLOCK, FIRST_LOCAL_BLOCK): Ditto. * block.c: New file. * block.h: New file. David Carlton carlton@math.stanford.edu