From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-18196-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 32676 invoked by alias); 28 Aug 2002 17:23:15 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 32663 invoked from network); 28 Aug 2002 17:23:15 -0000
Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136)
  by sources.redhat.com with SMTP; 28 Aug 2002 17:23:15 -0000
Received: (from carlton@localhost)
	by jackfruit.Stanford.EDU (8.11.6/8.11.6) id g7SHN7j17352;
	Wed, 28 Aug 2002 10:23:07 -0700
X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com, ezannoni@redhat.com
Subject: Re: RFA: Correct field names for class methods
References: <20020827031346.GA16591@nevyn.them.org>
Content-Type: text/plain; charset=US-ASCII
From: David Carlton <carlton@math.stanford.edu>
Date: Wed, 28 Aug 2002 10:26:00 -0000
In-Reply-To: <20020827031346.GA16591@nevyn.them.org>
Message-ID: <ro1ofbmhp8l.fsf@jackfruit.Stanford.EDU>
User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp)
MIME-Version: 1.0
X-SW-Source: 2002-08/txt/msg00946.txt.bz2

In article <20020827031346.GA16591@nevyn.them.org>, Daniel Jacobowitz
<drow@mvista.com> writes:
 
> +void
> +update_method_name_from_physname (char **old_name, char *physname)
> +{
> +  char *method_name;
> +
> +  method_name = method_name_from_physname (physname);
> +
> +  if (method_name == NULL)
> +    error ("bad physname %s\n", physname);
> +
> +  if (strcmp (*old_name, method_name) != 0)
> +    *old_name = method_name;
> +  else
> +    xfree (method_name);
> +}

I'm pretty sure this is a memory leak.  How about replacing the last
if clause by

  xfree(*old_name);
  *old_name = method_name;

That should get rid of the memory leak and avoid a superfluous
strcmp.

(Also, the ChangeLog entry has the name of this function written
incorrectly.)

David Carlton
carlton@math.stanford.edu