From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-19142-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 5628 invoked by alias); 1 Oct 2002 19:43:47 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 5621 invoked from network); 1 Oct 2002 19:43:45 -0000
Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136)
  by sources.redhat.com with SMTP; 1 Oct 2002 19:43:45 -0000
Received: (from carlton@localhost)
	by jackfruit.Stanford.EDU (8.11.6/8.11.6) id g91Jhhu30116;
	Tue, 1 Oct 2002 12:43:43 -0700
X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f
To: Daniel Jacobowitz <drow@mvista.com>
Cc: Michael Snyder <msnyder@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [rfa] more all-target -Werror patches
References: <ro1adlyuo7v.fsf@jackfruit.Stanford.EDU>
	<3D99F827.B5579C75@redhat.com> <20021001193711.GA28905@nevyn.them.org>
From: David Carlton <carlton@math.stanford.edu>
Date: Tue, 01 Oct 2002 12:43:00 -0000
In-Reply-To: <20021001193711.GA28905@nevyn.them.org>
Message-ID: <ro1ofaet05t.fsf@jackfruit.Stanford.EDU>
User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-10/txt/msg00014.txt.bz2

On Tue, 1 Oct 2002 15:37:12 -0400, Daniel Jacobowitz <drow@mvista.com> said:
> On Tue, Oct 01, 2002 at 12:31:51PM -0700, Michael Snyder wrote:

>> I'm uneasy about inserting semi-random stuff just to quiet a
>> compiler complaint that doesn't necessarily make sense (is the
>> compiler wrong?)  Certainly it should be documented if you do it,
>> else someone later may take it out, not knowing what it's there
>> for.

> Well, it's right.  Labels without any expression to label aren't
> legal C.

I'm glad to know it's right; on the other hand, I agree with Michael
that it should be documented.  How about I change the existing comment

  /* need to do something here */

to

  /* FIXME: We need to do something here.  For now, just put in a
     semicolon so the label has an expression to stick to.  (GCC will
     complain otherwise.)  */

And yes, I realize that FIXME's should ideally have a name attached to
them, but that name should be the author of the original comment
rather than mine, and I don't know who that is.

David Carlton
carlton@math.stanford.edu