From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14761 invoked by alias); 10 Apr 2003 20:34:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14743 invoked from network); 10 Apr 2003 20:34:53 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by sources.redhat.com with SMTP; 10 Apr 2003 20:34:53 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id h3AKYjv20324; Thu, 10 Apr 2003 13:34:45 -0700 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Elena Zannoni Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/TESTSUITE] annota1.exp fixes References: <16019.21217.67067.495012@localhost.redhat.com> <16021.43826.706488.188589@localhost.redhat.com> From: David Carlton Date: Thu, 10 Apr 2003 20:34:00 -0000 In-Reply-To: <16021.43826.706488.188589@localhost.redhat.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-04/txt/msg00214.txt.bz2 On Thu, 10 Apr 2003 13:34:42 -0400, Elena Zannoni said: > Hmm, I've reread the threads and I am none the wiser. We didn't ask the > emacs people, like Eli suggested. No. :-( > I have a revised patch, which works for my problem, but doesn't help > you. I was wondering if using something like matching on > (${longversion}|${shortversion}) would work. It's not the end of the world if my problem never gets solved: I'm used to seeing those failures, after all. It's a strange situation: my srcdir is just '.', so ${srcdir}/${subdir}/${srcfile} really is equivalent to ${subdir}/${srcfile}, GCC is just noticing that it can leave out the './' at the start when generating debug info. (I'm pretty sure I checked at the time and made sure that it's GCC that's getting rid of the './', not GDB.) So I'm happy enough with your patch; on the other hand, it will cause Kevin to start seeing failures with the IRIX compiler again, if I'm reading it right. How about this as a compromise: file a GDB external suspended PR mentioning that some compilers don't always put full path names in the debug info, have a pass branch with your new regexp, and have an xfail branch associated to that PR with your original more generous regexp? (I'm not sure we do this in the testsuite anywhere yet, but my understanding is that xfail takes an optional second argument, which is a PR number.) I think that's a good compromise: the test should remain useful, because if GDB ever regresses on this issue then presumably somebody will notice a pass->xfail transition. And we'll only be saying 'pass' in situations where we're sure we're doing the right thing. David Carlton carlton@math.stanford.edu