From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13524 invoked by alias); 7 Mar 2003 16:53:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13517 invoked from network); 7 Mar 2003 16:53:03 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by 172.16.49.205 with SMTP; 7 Mar 2003 16:53:03 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id h27Gr0420360; Fri, 7 Mar 2003 08:53:00 -0800 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [dictionary] commit for 2003-03-06 References: <20030307144017.GA20963@nevyn.them.org> From: David Carlton Date: Fri, 07 Mar 2003 16:53:00 -0000 In-Reply-To: <20030307144017.GA20963@nevyn.them.org> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-03/txt/msg00164.txt.bz2 On Fri, 7 Mar 2003 09:40:17 -0500, Daniel Jacobowitz said: > On Thu, Mar 06, 2003 at 04:52:56PM -0800, David Carlton wrote: >> Question for those of you who have read this far: now that >> lookup_symbol_aux_minsyms is on its last legs (it's gone on the >> branch), do you think we could get rid of the demangled hash table >> for minsyms? I'll try to audit uses of lookup_minimal_symbol >> tomorrow or next week. > No. Every time you talk about removing something with minimal > symbols, remember that we can use them to debug a program with no > symbolic debug info. Yeah, I think you're right. I was thinking about this last night, and I realized that decode_line_1 is a likely culprit: it needs to do minimal symbol lookups in order to be able to break on functions with no debug info. Except that, of course, the story isn't that simple: the only part of decode_line_1 that should care whether it uses the linkage name instead of the natural name is decode_compound, and that part of the code currently _doesn't_ do a lookup_minimal_symbol. Sigh. So, right now, I actually think we could get rid of the demangled hash table without causing any problems. But I think that should probably be considered a bug in decode_compound rather than a reason to get rid of the demangled hash table. And there might be uses elsewhere, too: I haven't yet audited all the uses of lookup_minimal_symbol. I'm fairly sure that the symbol lookup functions in symtab.c are safe, from memory, and there shouldn't be _too_ many other places that want a natural name when looking at minimal symbols, but there might be some. David Carlton carlton@math.stanford.edu