From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31380 invoked by alias); 1 Oct 2002 20:15:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31366 invoked from network); 1 Oct 2002 20:15:08 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by sources.redhat.com with SMTP; 1 Oct 2002 20:15:08 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id g91KF4a30154; Tue, 1 Oct 2002 13:15:04 -0700 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Daniel Jacobowitz Cc: Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [rfa] more all-target -Werror patches References: <3D99F827.B5579C75@redhat.com> <20021001193711.GA28905@nevyn.them.org> From: David Carlton Date: Tue, 01 Oct 2002 13:15:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-10/txt/msg00015.txt.bz2 On 01 Oct 2002 12:43:42 -0700, David Carlton said: > How about I change the existing comment > /* need to do something here */ > to > /* FIXME: We need to do something here. For now, just put in a > semicolon so the label has an expression to stick to. (GCC will > complain otherwise.) */ > And yes, I realize that FIXME's should ideally have a name attached to > them, but that name should be the author of the original comment > rather than mine, and I don't know who that is. Now that I look at the code, I'm really not sure what comment should go there. It's not clear to me what the intent of the original comment is: I'd assumed that it meant that there should be code after the retry label, but it's not at all clear to me why one would expect that to be the case: the function looks sensible enough as it is. So maybe I should leave the initial comment intact, and add the following comment: /* NOTE: carlton/2002-10-01: The semicolon is there so the label has an expression to stick to. (GCC will complain otherwise.) */ David Carlton carlton@math.stanford.edu