From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21024 invoked by alias); 23 Oct 2002 23:29:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21000 invoked from network); 23 Oct 2002 23:29:16 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by sources.redhat.com with SMTP; 23 Oct 2002 23:29:16 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id g9NNT6g20913; Wed, 23 Oct 2002 16:29:06 -0700 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Elena Zannoni Cc: gdb-patches@sources.redhat.com, Jim Blandy Subject: Re: [patch] useless code in symtab.c References: <15799.9088.601916.908293@localhost.redhat.com> <15799.10389.127424.360048@localhost.redhat.com> From: David Carlton Date: Wed, 23 Oct 2002 16:29:00 -0000 In-Reply-To: <15799.10389.127424.360048@localhost.redhat.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-10/txt/msg00495.txt.bz2 On Wed, 23 Oct 2002 18:54:13 -0400, Elena Zannoni said: > David Carlton writes: >> On Wed, 23 Oct 2002 18:32:32 -0400, Elena Zannoni said: >>> Can you also knock out the one at: >>> linespec.c:38:extern char *find_template_name_end (char *); >> That one gets used by decode_line_1. (One of these days, I'll try >> to understand what that function is doing, but I'm not feeling >> quite that masochistic yet.) Though I don't see any compelling >> reason not to just #include "parser-defs.h" there instead of >> declaring that one function specially; should I go ahead and do >> that? > decode_line_1, I think it will also make coffee if you ask > nicely.... :-( I really will have to give it a look; refactoring lookup_symbol_aux was fairly pleasant and has turned out to be quite useful for me, so at some point I'll see if decode_line_1 is amenable to a similar treament. Probably not, though: lookup_symbol_aux breaks fairly neatly into a few decent-sized chunks, whereas decode_line_1 is a good deal longer (770 lines as opposed to 370) and seems to me, upon a brief skim, to not want to break apart nearly as nicely. Incidentally, have you looked over the lookup_symbol_aux refactoring yet? (At .) It's not particularly urgent yet, but at some point I'm going to need to need to get some sort of consensus as to what it means to look something up in the global symbol table, and that patch is a good starting place for discussion. I think it's all a good idea except maybe I shouldn't move the partial symbol table lookup before the minimal symbol table lookup just yet. > Yes, please, and update the Makefile.in dependencies. Great, will do. David Carlton carlton@math.stanford.edu