From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2631 invoked by alias); 4 Feb 2003 01:18:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2624 invoked from network); 4 Feb 2003 01:18:20 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by 172.16.49.205 with SMTP; 4 Feb 2003 01:18:20 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id h141IJQ28737; Mon, 3 Feb 2003 17:18:19 -0800 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: gdb-patches@sources.redhat.com Cc: Michael Elizabeth Chastain Subject: [patch] KFAIL gdb/1025 From: David Carlton Date: Tue, 04 Feb 2003 01:18:00 -0000 Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-02/txt/msg00098.txt.bz2 I've been seeing some repeatable failures in gdb.c++/ovldbreak.exp; this patch KFAILs them, according to PR gdb/1025 that I just filed. Strangely enough, I'm seeing more failures than Michael does; he only sees 4, and those only with i686-pc-linux-gnu/GCC2.95.3/DWARF-2; I'm seeing 6 with i686-pc-linux-gnu/GCC3.{1,2}/DWARF2. I don't know what's weird about my setup. (For all I know, GCC might even be doing optimization that it shouldn't; it's not entirely clear to me from skimming the assembly code.) I've committed the attached patch. David Carlton carlton@math.stanford.edu 2003-02-03 David Carlton * gdb.c++/ovldbreak.exp (continue_to_bp_overloaded): Add 'might_kfail' arg. KFAIL some of the continue_to_bp_overloaded calls, according to PR c++/1025. Index: ovldbreak.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.c++/ovldbreak.exp,v retrieving revision 1.4 diff -u -p -r1.4 ovldbreak.exp --- ovldbreak.exp 18 Apr 2002 03:23:52 -0000 1.4 +++ ovldbreak.exp 4 Feb 2003 01:06:33 -0000 @@ -312,7 +312,11 @@ gdb_test "info break" \ # Run through each breakpoint. -proc continue_to_bp_overloaded {bpnumber argtype actuals} { +# NOTE: carlton/2003-02-03: I'm seeing failures on some of the tests, +# with the wrong arg being printed out. Michael Chastain sees +# failures at times, too, albeit fewer than I do. + +proc continue_to_bp_overloaded {might_kfail bpnumber argtype actuals} { global gdb_prompt hex decimal srcfile send_gdb "continue\n" @@ -320,6 +324,13 @@ proc continue_to_bp_overloaded {bpnumber -re "Continuing.\r\n\r\nBreakpoint ${bpnumber}, (${hex} in )?foo::overload1arg(\\(${argtype}\\))? \\(this=${hex}(, )?${actuals}\\) at.*${srcfile}:${decimal}\r\n${decimal}\[\t \]+int foo::overload1arg \\(${argtype}( arg)?\\).*\r\n.*$gdb_prompt $" { pass "continue to bp overloaded : ${argtype}" } + -re "Continuing.\r\n\r\nBreakpoint ${bpnumber}, (${hex} in )?foo::overload1arg(\\(${argtype}\\))? \\(this=${hex}, arg=.*\\) at.*${srcfile}:${decimal}\r\n${decimal}\[\t \]+int foo::overload1arg \\(${argtype}( arg)?\\).*\r\n.*$gdb_prompt $" { + if $might_kfail { + kfail "gdb/1025" "continue to bp overloaded : ${argtype}" + } else { + fail "continue to bp overloaded : ${argtype}" + } + } -re ".*$gdb_prompt $" { fail "continue to bp overloaded : ${argtype}" } @@ -329,18 +340,18 @@ proc continue_to_bp_overloaded {bpnumber } } -continue_to_bp_overloaded 25 "(void|)" "" -continue_to_bp_overloaded 24 "char" "arg=2 \\'\\\\002\\'" -continue_to_bp_overloaded 23 "signed char" "arg=3 \\'\\\\003\\'" -continue_to_bp_overloaded 22 "unsigned char" "arg=4 \\'\\\\004\\'" -continue_to_bp_overloaded 21 "short" "arg=5" -continue_to_bp_overloaded 20 "unsigned short" "arg=6" -continue_to_bp_overloaded 19 "int" "arg=7" -continue_to_bp_overloaded 18 "(unsigned|unsigned int)" "arg=8" -continue_to_bp_overloaded 17 "long" "arg=9" -continue_to_bp_overloaded 16 "unsigned long" "arg=10" -continue_to_bp_overloaded 15 "float" "arg=100" -continue_to_bp_overloaded 14 "double" "arg=200" +continue_to_bp_overloaded 0 25 "(void|)" "" +continue_to_bp_overloaded 1 24 "char" "arg=2 \\'\\\\002\\'" +continue_to_bp_overloaded 1 23 "signed char" "arg=3 \\'\\\\003\\'" +continue_to_bp_overloaded 1 22 "unsigned char" "arg=4 \\'\\\\004\\'" +continue_to_bp_overloaded 1 21 "short" "arg=5" +continue_to_bp_overloaded 1 20 "unsigned short" "arg=6" +continue_to_bp_overloaded 0 19 "int" "arg=7" +continue_to_bp_overloaded 0 18 "(unsigned|unsigned int)" "arg=8" +continue_to_bp_overloaded 0 17 "long" "arg=9" +continue_to_bp_overloaded 0 16 "unsigned long" "arg=10" +continue_to_bp_overloaded 0 15 "float" "arg=100" +continue_to_bp_overloaded 1 14 "double" "arg=200"