Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Carlton <carlton@math.stanford.edu>
To: Jim Blandy <jimb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [Jim Blandy <jimb@redhat.com>] RFA: Check that `Local' is not in scope when it shouldn't be
Date: Tue, 04 Feb 2003 22:16:00 -0000	[thread overview]
Message-ID: <ro1isvz3d5o.fsf@jackfruit.Stanford.EDU> (raw)
In-Reply-To: <vt2el6nww43.fsf@zenia.red-bean.com>

On 04 Feb 2003 16:53:48 -0500, Jim Blandy <jimb@redhat.com> said:
> David Carlton originally asked:

>> I'm confused: don't you want to do the first 'ptype Local' _before_
>> going up from foobar?  In which case your added test might as well
>> happen after you go up from foobar but before running to marker2.

> The test doesn't go up from foobar; it goes up from marker1, which is
> called from foobar, so the "up" makes foobar the current scope.

Oh, duh, sorry about that.

> Michael Chastain corrected the way I'd written the second kfail
> patch.  I believe I've done it right this time --- so that if the
> output changes from the current known incorrect output to anything
> other than the correct output, the known failure will become a
> straight failure.

Right.

> I couldn't figure out, though, why folks were advising me to use
> setup_kfail with a pattern that always matches, instead of simply
> calling kfail directly.  So I just used kfail.

Yes, kfail is better.

Approved; thanks for taking care of this.  My list of
non-{PASS,KFAIL}s in gdb.c++ is dwindling nicely.

David Carlton
carlton@math.stanford.edu


  reply	other threads:[~2003-02-04 22:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-20 10:56 Jim Blandy
2002-12-20 11:19 ` Daniel Jacobowitz
2002-12-20 12:05   ` David Carlton
2002-12-20 12:01 ` David Carlton
2002-12-20 12:18   ` David Carlton
2003-02-04 22:02 ` Jim Blandy
2003-02-04 22:16   ` David Carlton [this message]
2003-02-05  5:49     ` Jim Blandy
2002-12-20 21:12 Michael Elizabeth Chastain
2002-12-23 22:51 Michael Elizabeth Chastain
2003-02-05  6:23 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ro1isvz3d5o.fsf@jackfruit.Stanford.EDU \
    --to=carlton@math.stanford.edu \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox