From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7773 invoked by alias); 12 Jun 2003 17:05:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7754 invoked from network); 12 Jun 2003 17:05:55 -0000 Received: from unknown (HELO smtp8.Stanford.EDU) (171.67.16.35) by sources.redhat.com with SMTP; 12 Jun 2003 17:05:55 -0000 Received: (from root@localhost) by smtp8.Stanford.EDU (8.12.9/8.12.9) id h5CH5slm014344 for gdb-patches@sources.redhat.com; Thu, 12 Jun 2003 10:05:54 -0700 (PDT) Received: from jackfruit.Stanford.EDU (jackfruit.Stanford.EDU [171.64.38.136]) by smtp8.Stanford.EDU (8.12.9/8.12.9) with ESMTP id h5CH5nx2014326; Thu, 12 Jun 2003 10:05:50 -0700 (PDT) Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id h5CH5ng12340; Thu, 12 Jun 2003 10:05:49 -0700 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Andrew Cagney Cc: gdb-patches@sources.redhat.com, ezannoni@redhat.com, jimb@redhat.com Subject: Re: [commit] remove DEPRECATED_SYMBOL_NAME uses from symtab.c References: <3EE8B108.7020306@redhat.com> From: David Carlton Date: Thu, 12 Jun 2003 17:05:00 -0000 In-Reply-To: <3EE8B108.7020306@redhat.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-06/txt/msg00422.txt.bz2 On Thu, 12 Jun 2003 12:57:44 -0400, Andrew Cagney said: > Does this: >> #define COMPLETION_LIST_ADD_SYMBOL(symbol, sym_text, len, text, word) \ >> - do { \ >> - if (SYMBOL_DEMANGLED_NAME (symbol) != NULL) \ >> - /* Put only the mangled name on the list. */ \ >> - /* Advantage: "b foo" completes to "b foo(int, int)" */ \ >> - /* Disadvantage: "b foo__i" doesn't complete. */ \ >> completion_list_add_name \ >> - (SYMBOL_DEMANGLED_NAME (symbol), (sym_text), (len), (text), (word)); \ >> - else \ >> - completion_list_add_name \ >> - (DEPRECATED_SYMBOL_NAME (symbol), (sym_text), (len), (text), (word)); \ >> - } while (0) >> + (SYMBOL_NATURAL_NAME (symbol), (sym_text), (len), (text), (word)) > mean that COMPLETION_LIST_ADD_SYMBOL is also dead? (I have trouble > reading unified diffs :-) No, it's still there, it's just defined as follows now: #define COMPLETION_LIST_ADD_SYMBOL(symbol, sym_text, len, text, word) \ completion_list_add_name \ (SYMBOL_NATURAL_NAME (symbol), (sym_text), (len), (text), (word)) One could argue the wisdom of keeping it around as a separate macro, but that's a separate issue: all I wanted to do with that patch was clean up deprecated stuff. David Carlton carlton@math.stanford.edu